From: Thomas Monjalon <thomas@monjalon.net>
To: Joyce Kong <joyce.kong@arm.com>
Cc: ruifeng.wang@arm.com, bruce.richardson@intel.com, dev@dpdk.org,
nd@arm.com, Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Subject: Re: [PATCH v4 2/2] config/arm: use common cpu arch for cross files
Date: Sun, 18 Feb 2024 18:56:58 +0100 [thread overview]
Message-ID: <14316419.VsHLxoZxqI@thomas> (raw)
In-Reply-To: <20231205035259.3516625-3-joyce.kong@arm.com>
05/12/2023 04:52, Joyce Kong:
> The cpu info in some cross files is inconsistent with
> that in SoC flags. The mismatch doesn't cause any issue
> because the cpu field in the cross file takes no effect
> and machine_args in config/arm/meson.build actually works.
> Use a common one in cross files to remove any confusion.
>
> Reported-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
[...]
> --- a/config/arm/arm64_armada_linux_gcc
> +++ b/config/arm/arm64_armada_linux_gcc
> @@ -10,7 +10,7 @@ pcap-config = ''
> [host_machine]
> system = 'linux'
> cpu_family = 'aarch64'
> -cpu = 'armv8-a'
> +cpu = 'aarch64'
Why aarch64 here and below?
> --- a/config/arm/arm64_armv8_linux_clang_ubuntu
> +++ b/config/arm/arm64_armv8_linux_clang_ubuntu
> @@ -10,7 +10,7 @@ pkgconfig = 'aarch64-linux-gnu-pkg-config'
> [host_machine]
> system = 'linux'
> cpu_family = 'aarch64'
> -cpu = 'armv8-a'
> +cpu = 'auto'
[...]
> --- a/config/arm/arm64_hip10_linux_gcc
> +++ b/config/arm/arm64_hip10_linux_gcc
> @@ -9,7 +9,7 @@ pcap-config = ''
> [host_machine]
> system = 'linux'
> cpu_family = 'aarch64'
> -cpu = 'armv8-a'
> +cpu = 'aarch64'
next prev parent reply other threads:[~2024-02-18 17:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 7:47 [PATCH v1] config/arm: correct cpu arch for cross build Joyce Kong
2023-10-17 19:41 ` Thomas Monjalon
2023-10-18 5:40 ` Joyce Kong
2023-11-06 14:10 ` Thomas Monjalon
2023-11-06 14:31 ` Joyce Kong
2023-11-06 15:38 ` Thomas Monjalon
2023-11-07 2:42 ` Joyce Kong
2023-11-07 3:26 ` [PATCH v2] " Joyce Kong
2023-11-12 12:53 ` Thomas Monjalon
2023-11-20 8:51 ` Joyce Kong
2023-11-20 9:24 ` [PATCH v3] " Joyce Kong
2023-11-20 16:54 ` Thomas Monjalon
2023-11-22 7:10 ` Joyce Kong
2023-12-05 3:52 ` [PATCH v4 0/2] config changes " Joyce Kong
2023-12-05 3:52 ` [PATCH v4 1/2] config: correct cpu instruction set " Joyce Kong
2023-12-07 22:41 ` Stephen Hemminger
2023-12-08 2:51 ` Joyce Kong
2024-01-19 19:39 ` Pavan Nikhilesh Bhagavatula
2024-03-06 14:43 ` Thomas Monjalon
2023-12-05 3:52 ` [PATCH v4 2/2] config/arm: use common cpu arch for cross files Joyce Kong
2023-12-07 22:41 ` Stephen Hemminger
2024-01-19 19:40 ` [EXT] " Pavan Nikhilesh Bhagavatula
2024-02-18 17:56 ` Thomas Monjalon [this message]
2024-02-22 21:38 ` Wathsala Wathawana Vithanage
2024-03-06 14:43 ` Thomas Monjalon
2024-03-06 15:01 ` Wathsala Wathawana Vithanage
2024-03-06 15:04 ` Wathsala Wathawana Vithanage
2024-03-06 15:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14316419.VsHLxoZxqI@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=joyce.kong@arm.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).