[dpdk-dev] [PATCH 0/2] Add missing includes to headers

[dpdk-dev] [PATCH 0/2] Add missing includes to headers

[Bruce Richardson]

The convention in DPDK is that each header file should include 
any other headers on which it depends. This patch set adds in 
some missing header dependencies.

Bruce Richardson (2):
  eal: add missing include <stdio.h> to rte_pci.h
  kni: add missing include dependencies

 lib/librte_eal/common/include/rte_pci.h | 1 +
 lib/librte_kni/rte_kni.h                | 2 ++
 2 files changed, 3 insertions(+)

-- 
2.1.0

[dpdk-dev] [PATCH 1/2] eal: add missing include <stdio.h> to rte_pci.h

[Bruce Richardson]

rte_pci.h depends upon stdio.h for the definition of the FILE type. Add
in #include <stdio.h> to the file to satisfy this dependency in cases
where the including C file does not already include stdio.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/librte_eal/common/include/rte_pci.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h
index 223d3cd..a346532 100644
--- a/lib/librte_eal/common/include/rte_pci.h
+++ b/lib/librte_eal/common/include/rte_pci.h
@@ -74,6 +74,7 @@
 extern "C" {
 #endif
 
+#include <stdio.h>
 #include <stdlib.h>
 #include <limits.h>
 #include <errno.h>
-- 
2.1.0

Re: [dpdk-dev] [PATCH 1/2] eal: add missing include <stdio.h> to rte_pci.h

[Marc Sune]

On 25/05/15 14:23, Bruce Richardson wrote:
> rte_pci.h depends upon stdio.h for the definition of the FILE type. Add
> in #include <stdio.h> to the file to satisfy this dependency in cases
> where the including C file does not already include stdio.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   lib/librte_eal/common/include/rte_pci.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h
> index 223d3cd..a346532 100644
> --- a/lib/librte_eal/common/include/rte_pci.h
> +++ b/lib/librte_eal/common/include/rte_pci.h
> @@ -74,6 +74,7 @@
>   extern "C" {
>   #endif
>   
> +#include <stdio.h>
>   #include <stdlib.h>
>   #include <limits.h>
>   #include <errno.h>

Acked-by: Marc Sune <marc.sune@bisdn.de>

[dpdk-dev] [PATCH 2/2] kni: add missing include dependencies

[Bruce Richardson]

The file rte_kni.h depends upon a number of other headers, some of which
are missing from the #include lines. The following #includes are added:
 * rte_memory.h - for the definition of phys_addr_t
 * rte_mempool.h - for the definition of mempool struct and the mempool
   create function.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/librte_kni/rte_kni.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
index 98edd72..44240fe 100644
--- a/lib/librte_kni/rte_kni.h
+++ b/lib/librte_kni/rte_kni.h
@@ -47,6 +47,8 @@
  */
 
 #include <rte_pci.h>
+#include <rte_memory.h>
+#include <rte_mempool.h>
 
 #include <exec-env/rte_kni_common.h>
 
-- 
2.1.0

Re: [dpdk-dev] [PATCH 2/2] kni: add missing include dependencies

[Marc Sune]

On 25/05/15 14:23, Bruce Richardson wrote:
> The file rte_kni.h depends upon a number of other headers, some of which
> are missing from the #include lines. The following #includes are added:
>   * rte_memory.h - for the definition of phys_addr_t
>   * rte_mempool.h - for the definition of mempool struct and the mempool
>     create function.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   lib/librte_kni/rte_kni.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
> index 98edd72..44240fe 100644
> --- a/lib/librte_kni/rte_kni.h
> +++ b/lib/librte_kni/rte_kni.h
> @@ -47,6 +47,8 @@
>    */
>   
>   #include <rte_pci.h>
> +#include <rte_memory.h>
> +#include <rte_mempool.h>
>   
>   #include <exec-env/rte_kni_common.h>
>   

A fwd declaration of struct rte_mempool would be sufficient, but

Acked-by: Marc Sune <marc.sune@bisdn.de>

Re: [dpdk-dev] [PATCH 0/2] Add missing includes to headers

[Thomas Monjalon]

2015-05-25 13:23, Bruce Richardson:
> The convention in DPDK is that each header file should include 
> any other headers on which it depends. This patch set adds in 
> some missing header dependencies.
> 
> Bruce Richardson (2):
>   eal: add missing include <stdio.h> to rte_pci.h
>   kni: add missing include dependencies

Applied, thanks