From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E38786849 for ; Wed, 10 Jun 2015 17:25:35 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 10 Jun 2015 08:25:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,588,1427785200"; d="scan'208";a="708638111" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga001.jf.intel.com with ESMTP; 10 Jun 2015 08:25:28 -0700 Received: from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com [10.237.217.46]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id t5AFPRr8024225; Wed, 10 Jun 2015 16:25:28 +0100 Received: from sivswdev02.ir.intel.com (localhost [127.0.0.1]) by sivswdev02.ir.intel.com with ESMTP id t5AFPRH9014824; Wed, 10 Jun 2015 16:25:27 +0100 Received: (from pdelarax@localhost) by sivswdev02.ir.intel.com with id t5AFPRHk014820; Wed, 10 Jun 2015 16:25:27 +0100 From: Pablo de Lara To: dev@dpdk.org Date: Wed, 10 Jun 2015 16:25:20 +0100 Message-Id: <1433949927-14767-4-git-send-email-pablo.de.lara.guarch@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1433949927-14767-1-git-send-email-pablo.de.lara.guarch@intel.com> References: <1432289771-12799-1-git-send-email-pablo.de.lara.guarch@intel.com> <1433949927-14767-1-git-send-email-pablo.de.lara.guarch@intel.com> Subject: [dpdk-dev] [PATCH v6 03/10] test/hash: update key size range and initial values for testing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2015 15:25:36 -0000 Previous key sizes used for testing did not have much purpose. This patch substitutes them with some more meaninful (standard multiple of 2 key sizes, plus IPv4/v6 tuple and others) Also an arbitrary initial value has been added to increase the test coverage, and RTE_DIM macro is used to iterate the loops. Signed-off-by: Pablo de Lara --- app/test/test_hash_functions.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/app/test/test_hash_functions.c b/app/test/test_hash_functions.c index 767b2bc..aff5e6d 100644 --- a/app/test/test_hash_functions.c +++ b/app/test/test_hash_functions.c @@ -57,8 +57,14 @@ #define HASHTEST_ITERATIONS 1000000 static rte_hash_function hashtest_funcs[] = {rte_jhash, rte_hash_crc}; -static uint32_t hashtest_initvals[] = {0}; -static uint32_t hashtest_key_lens[] = {2, 4, 5, 6, 7, 8, 10, 11, 15, 16, 21, 31, 32, 33, 63, 64}; +static uint32_t hashtest_initvals[] = {0, 0xdeadbeef}; +static uint32_t hashtest_key_lens[] = { + 4, 8, 16, 32, 48, 64, /* standard key sizes */ + 9, /* IPv4 SRC + DST + protocol, unpadded */ + 13, /* IPv4 5-tuple, unpadded */ + 37, /* IPv6 5-tuple, unpadded */ + 40 /* IPv6 5-tuple, padded to 8-byte boundary */ +}; /******************************************************************************/ /* @@ -115,15 +121,9 @@ run_hash_func_perf_tests(void) HASHTEST_ITERATIONS); printf("Hash Func. , Key Length (bytes), Initial value, Ticks/Op.\n"); - for (i = 0; - i < sizeof(hashtest_funcs) / sizeof(rte_hash_function); - i++) { - for (j = 0; - j < sizeof(hashtest_initvals) / sizeof(uint32_t); - j++) { - for (k = 0; - k < sizeof(hashtest_key_lens) / sizeof(uint32_t); - k++) { + for (i = 0; i < RTE_DIM(hashtest_funcs); i++) { + for (j = 0; j < RTE_DIM(hashtest_initvals); j++) { + for (k = 0; k < RTE_DIM(hashtest_key_lens); k++) { run_hash_func_perf_test(hashtest_funcs[i], hashtest_initvals[j], hashtest_key_lens[k]); -- 2.4.2