* [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue
@ 2020-02-17 16:43 taox.zhu
2020-02-17 11:19 ` David Marchand
2020-02-17 13:06 ` Jerin Jacob
0 siblings, 2 replies; 8+ messages in thread
From: taox.zhu @ 2020-02-17 16:43 UTC (permalink / raw)
To: jerinj, ndabilpuram, vattunuru; +Cc: dev, Tao Zhu
From: Tao Zhu <taox.zhu@intel.com>
Change the definition of C99 style to C90 style.
compile log as below:
otx2_mempool_ops.c: In function ‘otx2_npa_populate’:
/dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: error: \
‘for’ loop initial declarations are only allowed in C99 mode
for (int i = 0; i < OTX2_L1D_NB_SETS; i++)
^
/dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: \
note: use option -std=c99 or -std=gnu99 to compile your code
/dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c: At top level:
cc1: error: unrecognized command line option \
"-Wno-address-of-packed-member" [-Werror]
cc1: all warnings being treated as errors
make[6]: *** [otx2_mempool_ops.o] Error 1
make[5]: *** [octeontx2] Error 2
make[4]: *** [mempool] Error 2
Fixes: 9ed8e95c ("mempool/octeontx2: optimize for L1D cache architecture")
Signed-off-by: Tao Zhu <taox.zhu@intel.com>
---
drivers/mempool/octeontx2/otx2_mempool_ops.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempool/octeontx2/otx2_mempool_ops.c
index 6b55447..ac2d618 100644
--- a/drivers/mempool/octeontx2/otx2_mempool_ops.c
+++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c
@@ -754,6 +754,7 @@
size_t total_elt_sz;
uint8_t set;
size_t off;
+ int i;
if (iova == RTE_BAD_IOVA)
return -EINVAL;
@@ -787,7 +788,7 @@
otx2_npa_dbg("requested objects %"PRIu64", possible objects %"PRIu64"",
(uint64_t)max_objs, (uint64_t)(len / total_elt_sz));
otx2_npa_dbg("L1D set distribution :");
- for (int i = 0; i < OTX2_L1D_NB_SETS; i++)
+ for (i = 0; i < OTX2_L1D_NB_SETS; i++)
otx2_npa_dbg("set[%d] : objects : %"PRIu64"", i,
distribution[i]);
--
1.8.3.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue
2020-02-17 16:43 [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue taox.zhu
@ 2020-02-17 11:19 ` David Marchand
2020-02-17 14:57 ` David Marchand
2020-02-17 13:06 ` Jerin Jacob
1 sibling, 1 reply; 8+ messages in thread
From: David Marchand @ 2020-02-17 11:19 UTC (permalink / raw)
To: taox.zhu
Cc: Jerin Jacob Kollanukkaran, Nithin Dabilpuram, Vamsi Attunuru,
dev, Jeremy Plsek, Bruce Richardson, Aaron Conole
This patch has been sent with a date in the future.
Date: Mon, 17 Feb 2020 16:43:45 +0000
Please fix your mail setup, this triggers an error with meson in UNH
CI (at least).
--
David Marchand
On Mon, Feb 17, 2020 at 9:09 AM <taox.zhu@intel.com> wrote:
>
> From: Tao Zhu <taox.zhu@intel.com>
>
> Change the definition of C99 style to C90 style.
> compile log as below:
>
> otx2_mempool_ops.c: In function ‘otx2_npa_populate’:
> /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: error: \
> ‘for’ loop initial declarations are only allowed in C99 mode
> for (int i = 0; i < OTX2_L1D_NB_SETS; i++)
> ^
> /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: \
> note: use option -std=c99 or -std=gnu99 to compile your code
> /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c: At top level:
> cc1: error: unrecognized command line option \
> "-Wno-address-of-packed-member" [-Werror]
> cc1: all warnings being treated as errors
> make[6]: *** [otx2_mempool_ops.o] Error 1
> make[5]: *** [octeontx2] Error 2
> make[4]: *** [mempool] Error 2
>
> Fixes: 9ed8e95c ("mempool/octeontx2: optimize for L1D cache architecture")
>
> Signed-off-by: Tao Zhu <taox.zhu@intel.com>
> ---
> drivers/mempool/octeontx2/otx2_mempool_ops.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempool/octeontx2/otx2_mempool_ops.c
> index 6b55447..ac2d618 100644
> --- a/drivers/mempool/octeontx2/otx2_mempool_ops.c
> +++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c
> @@ -754,6 +754,7 @@
> size_t total_elt_sz;
> uint8_t set;
> size_t off;
> + int i;
>
> if (iova == RTE_BAD_IOVA)
> return -EINVAL;
> @@ -787,7 +788,7 @@
> otx2_npa_dbg("requested objects %"PRIu64", possible objects %"PRIu64"",
> (uint64_t)max_objs, (uint64_t)(len / total_elt_sz));
> otx2_npa_dbg("L1D set distribution :");
> - for (int i = 0; i < OTX2_L1D_NB_SETS; i++)
> + for (i = 0; i < OTX2_L1D_NB_SETS; i++)
> otx2_npa_dbg("set[%d] : objects : %"PRIu64"", i,
> distribution[i]);
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue
2020-02-17 11:19 ` David Marchand
@ 2020-02-17 14:57 ` David Marchand
2020-02-17 18:04 ` Jeremy Plsek
0 siblings, 1 reply; 8+ messages in thread
From: David Marchand @ 2020-02-17 14:57 UTC (permalink / raw)
To: Jeremy Plsek
Cc: Nithin Dabilpuram, Vamsi Attunuru, dev, Bruce Richardson,
Aaron Conole, taox.zhu, Jerin Jacob Kollanukkaran
Jeremy,
On Mon, Feb 17, 2020 at 12:19 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> This patch has been sent with a date in the future.
> Date: Mon, 17 Feb 2020 16:43:45 +0000
>
> Please fix your mail setup, this triggers an error with meson in UNH
> CI (at least).
Do you use the tools/pwclient script from dpdk-ci or some git-am
script of yours?
I can see git-am has an option to tweak the commit dates (--ignore-date).
This should avoid the issue of files in the future that meson is not happy with.
--
David Marchand
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue
2020-02-17 14:57 ` David Marchand
@ 2020-02-17 18:04 ` Jeremy Plsek
2020-02-17 18:28 ` Thomas Monjalon
0 siblings, 1 reply; 8+ messages in thread
From: Jeremy Plsek @ 2020-02-17 18:04 UTC (permalink / raw)
To: David Marchand
Cc: Nithin Dabilpuram, Vamsi Attunuru, dev, Bruce Richardson,
Aaron Conole, taox.zhu, Jerin Jacob Kollanukkaran
On Mon, Feb 17, 2020 at 9:57 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> Jeremy,
>
> On Mon, Feb 17, 2020 at 12:19 PM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > This patch has been sent with a date in the future.
> > Date: Mon, 17 Feb 2020 16:43:45 +0000
> >
> > Please fix your mail setup, this triggers an error with meson in UNH
> > CI (at least).
>
> Do you use the tools/pwclient script from dpdk-ci or some git-am
> script of yours?
We use a customized script given to us by the Intel CI team which does
use git-am.
> I can see git-am has an option to tweak the commit dates (--ignore-date).
I can look into adding it.
I've also updated our compile scripts (again) to hopefully mitigate
the issue. I've also rerun the tests for this patch with those
changes.
>
> This should avoid the issue of files in the future that meson is not happy with.
>
>
> --
> David Marchand
>
--
Jeremy Plsek
UNH InterOperability Laboratory
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue
2020-02-17 18:04 ` Jeremy Plsek
@ 2020-02-17 18:28 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2020-02-17 18:28 UTC (permalink / raw)
To: Jeremy Plsek
Cc: David Marchand, dev, Nithin Dabilpuram, Vamsi Attunuru, dev,
Bruce Richardson, Aaron Conole, taox.zhu,
Jerin Jacob Kollanukkaran
17/02/2020 19:04, Jeremy Plsek:
> On Mon, Feb 17, 2020 at 9:57 AM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > Jeremy,
> >
> > On Mon, Feb 17, 2020 at 12:19 PM David Marchand
> > <david.marchand@redhat.com> wrote:
> > >
> > > This patch has been sent with a date in the future.
> > > Date: Mon, 17 Feb 2020 16:43:45 +0000
> > >
> > > Please fix your mail setup, this triggers an error with meson in UNH
> > > CI (at least).
> >
> > Do you use the tools/pwclient script from dpdk-ci or some git-am
> > script of yours?
>
> We use a customized script given to us by the Intel CI team which does
> use git-am.
>
> > I can see git-am has an option to tweak the commit dates (--ignore-date).
>
> I can look into adding it.
>
> I've also updated our compile scripts (again) to hopefully mitigate
> the issue. I've also rerun the tests for this patch with those
> changes.
We need to revisit how to migrate to small public scripts in dpdk-ci
which can be re-used by anybody working on DPDK.
Please let's start with this one: a script for applying patches
from patchwork, using git-pw or git-am.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue
2020-02-17 16:43 [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue taox.zhu
2020-02-17 11:19 ` David Marchand
@ 2020-02-17 13:06 ` Jerin Jacob
2020-02-17 14:57 ` David Marchand
2020-02-17 18:29 ` Thomas Monjalon
1 sibling, 2 replies; 8+ messages in thread
From: Jerin Jacob @ 2020-02-17 13:06 UTC (permalink / raw)
To: taox.zhu; +Cc: Jerin Jacob, Nithin Dabilpuram, Vamsi Attunuru, dpdk-dev
On Mon, Feb 17, 2020 at 1:39 PM <taox.zhu@intel.com> wrote:
>
> From: Tao Zhu <taox.zhu@intel.com>
>
> Change the definition of C99 style to C90 style.
> compile log as below:
>
> otx2_mempool_ops.c: In function ‘otx2_npa_populate’:
> /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: error: \
> ‘for’ loop initial declarations are only allowed in C99 mode
> for (int i = 0; i < OTX2_L1D_NB_SETS; i++)
> ^
> /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: \
> note: use option -std=c99 or -std=gnu99 to compile your code
> /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c: At top level:
> cc1: error: unrecognized command line option \
> "-Wno-address-of-packed-member" [-Werror]
> cc1: all warnings being treated as errors
> make[6]: *** [otx2_mempool_ops.o] Error 1
> make[5]: *** [octeontx2] Error 2
> make[4]: *** [mempool] Error 2
>
> Fixes: 9ed8e95c ("mempool/octeontx2: optimize for L1D cache architecture")
>
> Signed-off-by: Tao Zhu <taox.zhu@intel.com>
Just for understanding purposes, Why one need to use C90 instead of
C99? May I know, What environment, Do you see this issue?
In any case,
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
> ---
> drivers/mempool/octeontx2/otx2_mempool_ops.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempool/octeontx2/otx2_mempool_ops.c
> index 6b55447..ac2d618 100644
> --- a/drivers/mempool/octeontx2/otx2_mempool_ops.c
> +++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c
> @@ -754,6 +754,7 @@
> size_t total_elt_sz;
> uint8_t set;
> size_t off;
> + int i;
>
> if (iova == RTE_BAD_IOVA)
> return -EINVAL;
> @@ -787,7 +788,7 @@
> otx2_npa_dbg("requested objects %"PRIu64", possible objects %"PRIu64"",
> (uint64_t)max_objs, (uint64_t)(len / total_elt_sz));
> otx2_npa_dbg("L1D set distribution :");
> - for (int i = 0; i < OTX2_L1D_NB_SETS; i++)
> + for (i = 0; i < OTX2_L1D_NB_SETS; i++)
> otx2_npa_dbg("set[%d] : objects : %"PRIu64"", i,
> distribution[i]);
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue
2020-02-17 13:06 ` Jerin Jacob
@ 2020-02-17 14:57 ` David Marchand
2020-02-17 18:29 ` Thomas Monjalon
1 sibling, 0 replies; 8+ messages in thread
From: David Marchand @ 2020-02-17 14:57 UTC (permalink / raw)
To: Jerin Jacob
Cc: taox.zhu, Jerin Jacob, Nithin Dabilpuram, Vamsi Attunuru,
dpdk-dev, Luca Boccassi
On Mon, Feb 17, 2020 at 2:06 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> On Mon, Feb 17, 2020 at 1:39 PM <taox.zhu@intel.com> wrote:
> >
> > From: Tao Zhu <taox.zhu@intel.com>
> >
> > Change the definition of C99 style to C90 style.
> > compile log as below:
> >
> > otx2_mempool_ops.c: In function ‘otx2_npa_populate’:
> > /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: error: \
> > ‘for’ loop initial declarations are only allowed in C99 mode
> > for (int i = 0; i < OTX2_L1D_NB_SETS; i++)
> > ^
> > /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: \
> > note: use option -std=c99 or -std=gnu99 to compile your code
> > /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c: At top level:
> > cc1: error: unrecognized command line option \
> > "-Wno-address-of-packed-member" [-Werror]
> > cc1: all warnings being treated as errors
> > make[6]: *** [otx2_mempool_ops.o] Error 1
> > make[5]: *** [octeontx2] Error 2
> > make[4]: *** [mempool] Error 2
> >
> > Fixes: 9ed8e95c ("mempool/octeontx2: optimize for L1D cache architecture")
> >
> > Signed-off-by: Tao Zhu <taox.zhu@intel.com>
>
> Just for understanding purposes, Why one need to use C90 instead of
> C99? May I know, What environment, Do you see this issue?
> In any case,
>
> Reviewed-by: Jerin Jacob <jerinj@marvell.com>
We can see this in RHEL/Centos 7 and SLE 12 (thanks Luca).
--
David Marchand
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue
2020-02-17 13:06 ` Jerin Jacob
2020-02-17 14:57 ` David Marchand
@ 2020-02-17 18:29 ` Thomas Monjalon
1 sibling, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2020-02-17 18:29 UTC (permalink / raw)
To: taox.zhu
Cc: dev, Jerin Jacob, Nithin Dabilpuram, Vamsi Attunuru, dpdk-dev,
Jerin Jacob
17/02/2020 14:06, Jerin Jacob:
> On Mon, Feb 17, 2020 at 1:39 PM <taox.zhu@intel.com> wrote:
> >
> > From: Tao Zhu <taox.zhu@intel.com>
> >
> > Change the definition of C99 style to C90 style.
> > compile log as below:
> >
> > otx2_mempool_ops.c: In function ‘otx2_npa_populate’:
> > /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: error: \
> > ‘for’ loop initial declarations are only allowed in C99 mode
> > for (int i = 0; i < OTX2_L1D_NB_SETS; i++)
> > ^
> > /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: \
> > note: use option -std=c99 or -std=gnu99 to compile your code
> > /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c: At top level:
> > cc1: error: unrecognized command line option \
> > "-Wno-address-of-packed-member" [-Werror]
> > cc1: all warnings being treated as errors
> > make[6]: *** [otx2_mempool_ops.o] Error 1
> > make[5]: *** [octeontx2] Error 2
> > make[4]: *** [mempool] Error 2
> >
> > Fixes: 9ed8e95c ("mempool/octeontx2: optimize for L1D cache architecture")
> >
> > Signed-off-by: Tao Zhu <taox.zhu@intel.com>
>
> Just for understanding purposes, Why one need to use C90 instead of
> C99? May I know, What environment, Do you see this issue?
> In any case,
>
> Reviewed-by: Jerin Jacob <jerinj@marvell.com>
Applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-02-17 18:29 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-17 16:43 [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue taox.zhu
2020-02-17 11:19 ` David Marchand
2020-02-17 14:57 ` David Marchand
2020-02-17 18:04 ` Jeremy Plsek
2020-02-17 18:28 ` Thomas Monjalon
2020-02-17 13:06 ` Jerin Jacob
2020-02-17 14:57 ` David Marchand
2020-02-17 18:29 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).