From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A937F106B for ; Tue, 7 Jul 2015 11:18:28 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 07 Jul 2015 02:18:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,422,1432623600"; d="scan'208";a="759718954" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga002.jf.intel.com with ESMTP; 07 Jul 2015 02:18:26 -0700 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id t679IOto003501; Tue, 7 Jul 2015 10:18:25 +0100 Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id t679IOV2028612; Tue, 7 Jul 2015 10:18:24 +0100 Received: (from bairemon@localhost) by sivswdev01.ir.intel.com with id t679IODF028607; Tue, 7 Jul 2015 10:18:24 +0100 From: Bernard Iremonger To: dev@dpdk.org Date: Tue, 7 Jul 2015 10:18:05 +0100 Message-Id: <1436260687-28549-3-git-send-email-bernard.iremonger@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1436260687-28549-1-git-send-email-bernard.iremonger@intel.com> References: <1436260687-28549-1-git-send-email-bernard.iremonger@intel.com> Subject: [dpdk-dev] [PATCH v4 2/4] virtio: check vq parameter in virtqueue_detatch_unused() function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2015 09:18:29 -0000 If vq is NULL, there is a segmentation fault. Signed-off-by: Bernard Iremonger --- drivers/net/virtio/virtqueue.c | 14 ++++++++------ 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c index 8a3005f..7f60e3e 100644 --- a/drivers/net/virtio/virtqueue.c +++ b/drivers/net/virtio/virtqueue.c @@ -1,7 +1,7 @@ /*- * BSD LICENSE * - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. + * Copyright(c) 2010-2015 Intel Corporation. All rights reserved. * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -60,11 +60,13 @@ virtqueue_detatch_unused(struct virtqueue *vq) struct rte_mbuf *cookie; int idx; - for (idx = 0; idx < vq->vq_nentries; idx++) { - if ((cookie = vq->vq_descx[idx].cookie) != NULL) { - vq->vq_descx[idx].cookie = NULL; - return cookie; + if (vq != NULL) + for (idx = 0; idx < vq->vq_nentries; idx++) { + cookie = vq->vq_descx[idx].cookie; + if (cookie != NULL) { + vq->vq_descx[idx].cookie = NULL; + return cookie; + } } - } return NULL; } -- 1.7.4.1