From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 56974C324 for ; Tue, 21 Jul 2015 17:25:37 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 21 Jul 2015 08:25:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,516,1432623600"; d="scan'208";a="732810819" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga001.jf.intel.com with ESMTP; 21 Jul 2015 08:25:09 -0700 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id t6LFP8Fc016762; Tue, 21 Jul 2015 16:25:08 +0100 Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id t6LFP7mO029789; Tue, 21 Jul 2015 16:25:07 +0100 Received: (from bricha3@localhost) by sivswdev01.ir.intel.com with id t6LFP72v029785; Tue, 21 Jul 2015 16:25:07 +0100 From: Bruce Richardson To: dev@dpdk.org Date: Tue, 21 Jul 2015 16:25:07 +0100 Message-Id: <1437492307-29754-1-git-send-email-bruce.richardson@intel.com> X-Mailer: git-send-email 1.7.4.1 Subject: [dpdk-dev] [PATCH] ixgbe: fix check for split packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2015 15:25:37 -0000 The check for split packets to be reassembled in the vector ixgbe PMD was incorrectly only checking the first 16 elements of the array instead of all 32. This is fixed by changing the uint32_t values to be uint64_t instead. Fixes: cf4b4708a88a ("ixgbe: improve slow-path perf with vector scattered Rx") Reported-by: Zoltan Kiss Signed-off-by: Bruce Richardson --- drivers/net/ixgbe/ixgbe_rxtx_vec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec.c b/drivers/net/ixgbe/ixgbe_rxtx_vec.c index 9f24849..cdad3e0 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx_vec.c +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec.c @@ -549,7 +549,7 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, return 0; /* happy day case, full burst + no packets to be joined */ - const uint32_t *split_fl32 = (uint32_t *)split_flags; + const uint64_t *split_fl32 = (uint64_t *)split_flags; if (rxq->pkt_first_seg == NULL && split_fl32[0] == 0 && split_fl32[1] == 0 && split_fl32[2] == 0 && split_fl32[3] == 0) -- 1.8.3.1