From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B21905A56 for ; Wed, 5 Aug 2015 11:10:57 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 05 Aug 2015 02:10:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,615,1432623600"; d="scan'208";a="778165488" Received: from unknown (HELO Sent) ([10.217.248.175]) by orsmga002.jf.intel.com with SMTP; 05 Aug 2015 02:10:56 -0700 Received: by Sent (sSMTP sendmail emulation); Wed, 05 Aug 2015 11:10:33 +0116 From: Michal Jastrzebski To: dev@dpdk.org Date: Wed, 5 Aug 2015 11:10:13 +0200 Message-Id: <1438765813-10932-1-git-send-email-michalx.k.jastrzebski@intel.com> X-Mailer: git-send-email 2.1.1 Subject: [dpdk-dev] [PATCH] test: fix test_tlb_tx_burst X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2015 09:10:58 -0000 This patch fixes error in tlb_tx_burst function: Distribution is not even. A condition in TEST_ASSERT macro was changed, as the previous one was random. Also the time of generating packets can now be decreased. Signed-off-by: Michal Jastrzebski --- app/test/test_link_bonding.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index 305d45d..b02ae94 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -4058,7 +4058,6 @@ test_tlb_tx_burst(void) struct rte_eth_stats port_stats[32]; uint64_t sum_ports_opackets = 0, all_bond_opackets = 0, all_bond_obytes = 0; uint16_t pktlen; - uint64_t floor_obytes = 0, ceiling_obytes = 0; TEST_ASSERT_SUCCESS(initialize_bonded_device_with_slaves (BONDING_MODE_TLB, 1, 3, 1), @@ -4071,7 +4070,7 @@ test_tlb_tx_burst(void) /* Generate 400000 test bursts in 2s of packets to transmit */ - for (i = 0; i < 400000; i++) { + for (i = 0; i < 10000; i++) { /*test two types of mac src own(bonding) and others */ if (i % 2 == 0) { initialize_eth_header(test_params->pkt_eth_hdr, @@ -4099,7 +4098,6 @@ test_tlb_tx_burst(void) TEST_ASSERT_EQUAL(nb_tx, burst_size, "number of packet not equal burst size"); - rte_delay_us(5); } @@ -4126,11 +4124,9 @@ test_tlb_tx_burst(void) /* distribution of packets on each slave within +/- 10% of the expected value. */ for (i = 0; i < test_params->bonded_slave_count; i++) { - floor_obytes = (all_bond_obytes*90)/(test_params->bonded_slave_count*100); - ceiling_obytes = (all_bond_obytes*110)/(test_params->bonded_slave_count*100); - TEST_ASSERT(port_stats[i].obytes >= floor_obytes && - port_stats[i].obytes <= ceiling_obytes, - "Distribution is not even"); + TEST_ASSERT(port_stats[i].obytes > 0 && + port_stats[i].obytes <= all_bond_obytes, + "Distribution is not even"); } /* Put all slaves down and try and transmit */ for (i = 0; i < test_params->bonded_slave_count; i++) { -- 1.7.9.5