From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 79D137D04; Wed, 26 Sep 2018 15:50:50 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 17C5321BEB; Wed, 26 Sep 2018 09:50:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 26 Sep 2018 09:50:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=uOrXX2pKNpPdrd+ZChMajz7QTZ WlqnfEgP6iU01onL0=; b=quDParsxaDj/f0oRuJS6SnduRCKOjMV8U8FMcUPjOP JO96VRyQQLjQrfbXOeArYsMJzW6C4t7mATCMy8Wcihw5Pvkj0cwaaJiSA6K3uhd3 SqF4ypSknY8k9R9r/O+h5+5GTizWPF5aQR6uEfFDaUwnzAArgSjg746jEZazhcvI Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=uOrXX2 pKNpPdrd+ZChMajz7QTZWlqnfEgP6iU01onL0=; b=YB6c/iCte0GNYPHPCOhUQ6 2PX+JQOth/To3jDKE7JB643UQxB71Mn97o8ZY26Ea3ojlaS6jkeQ4qE1Z1DEOd+M oMC8zgKewrz+1/Wbr9krBa1dLYhLPkjVGG1w86NSx3xlNCH/pKS2KEPM2P2s0eCW 6G8mVnq8Bg6/hsF2wFR2js8Jzv1AdShuA1hVwoOWuq7/3vrVr/QHWyc7bk+xnf/M tO88frmx9KnYjfphktcLJxxCX/AcXxwZNG00FPNYG5rPMgDCiYt+rm+BkFgPT6nY 80vvepG5lmqpXEU0/5KJBEVaIRO/LhssbDIc7wkV5NCCa09l7bU7kL5to8ddmMHQ == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 90586102E4; Wed, 26 Sep 2018 09:50:48 -0400 (EDT) From: Thomas Monjalon To: Qi Zhang Cc: dev@dpdk.org, anatoly.burakov@intel.com, ferruh.yigit@intel.com, geoffrey.lv@gmail.com, ajit.khaparde@broadcom.com, stable@dpdk.org Date: Wed, 26 Sep 2018 15:50:47 +0200 Message-ID: <14389377.uLlNGEYteW@xps> In-Reply-To: <20180903084005.29706-1-qi.z.zhang@intel.com> References: <20180903084005.29706-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix unexpected resource mapping override X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 13:50:50 -0000 Hi, 03/09/2018 10:40, Qi Zhang: > When scanning an already plugged device, the virtual address > of mapped PCI resource in rte_pci_device will be overridden > with 0, that may cause driver does not work correctly. Why is it overridden with 0? Can we try to fix the root cause? > The fix is not to update any rte_pci_device's field if the being > scanned device's driver is already probed. I am going to send a patch to have a safer way of checking whether a device is probed or not. If this change is really needed, I suggest to rebase it on top my patch.