From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 268258E9C for ; Wed, 19 Aug 2015 11:53:05 +0200 (CEST) Received: by paccq16 with SMTP id cq16so110635586pac.1 for ; Wed, 19 Aug 2015 02:53:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Oo94a3NydgFcrfGDXSYgbLwysyx+k+8PFXJJs/UIV38=; b=RNhc0nDfkRgm2trQthlQ7aLG7PRZ0kRT1v/cY9YtT2YT9GPxbWuxr59TjFTLe8nzK4 2XPc4xfEhX54ti8mVo1tc5l/3GtDxGHXfop7aJn84cHCj5Dirr3WX7s4QlsP9KDHnXJs Sa9rgLOJ6bryx2VL3Ndh9BYsDWOucW5qtZ3IWlPWABWzK+3nSJKwfJnjVkVrYQPtUzxr WQHylOCqzbrL8/nIBww4L3bsm95QgMCZsNt1QGWJxnFjUaIOpq8dJdlxSdhWsIdZmyrq OGFe1NJ2dgnBDu02P0tswt1tpUiSbUGlIikbkGdyhB+gz4xG3Kq83DgkloVWqAHbGZl9 Xg0w== X-Gm-Message-State: ALoCoQnK+LUEISNTwYMrZIni1t3SuAHjagcT+yC0MqRyuGZpWjFf1H5RRy1JlLgNdMwL9+QQVX4U X-Received: by 10.68.241.103 with SMTP id wh7mr22952811pbc.88.1439977984585; Wed, 19 Aug 2015 02:53:04 -0700 (PDT) Received: from localhost.localdomain (napt.igel.co.jp. [219.106.231.132]) by smtp.gmail.com with ESMTPSA id qe3sm212368pbc.73.2015.08.19.02.53.03 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 19 Aug 2015 02:53:04 -0700 (PDT) From: Tetsuya Mukawa To: dev@dpdk.org Date: Wed, 19 Aug 2015 18:51:09 +0900 Message-Id: <1439977869-28091-3-git-send-email-mukawa@igel.co.jp> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1439977869-28091-1-git-send-email-mukawa@igel.co.jp> References: <1439977869-28091-1-git-send-email-mukawa@igel.co.jp> Subject: [dpdk-dev] [PATCH 3/3] vhost: Fix RESET_OWNER handling not to free virtqueue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2015 09:53:05 -0000 When RESET_OWNER message is issued, vhost backend should not clear and free virtqueue memories. This is because vhost backend should handle GET_VRING_BASE message followed by the RESET_OWNER, so still vhost backend need to access virtqueue memories. These memories should be freed when SET_MEM_TABLE message is issued, and vhost library has already had such a functionality. Signed-off-by: Tetsuya Mukawa --- lib/librte_vhost/virtio-net.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c index 7794e8b..9475d00 100644 --- a/lib/librte_vhost/virtio-net.c +++ b/lib/librte_vhost/virtio-net.c @@ -182,13 +182,6 @@ add_config_ll_entry(struct virtio_net_config_ll *new_ll_dev) static void cleanup_device(struct virtio_net *dev) { - /* Unmap QEMU memory file if mapped. */ - if (dev->mem) { - munmap((void *)(uintptr_t)dev->mem->mapped_address, - (size_t)dev->mem->mapped_size); - free(dev->mem); - } - /* Close kickfd event notifiers opened by device. */ if ((int)dev->virtqueue[VIRTIO_RXQ]->kickfd >= 0) close((int)dev->virtqueue[VIRTIO_RXQ]->kickfd); -- 2.1.4