Re: [PATCH v3 2/5] mbuf: record mbuf operations history

[Thomas Monjalon <thomas@monjalon.net>]

02/10/2025 09:37, Morten Brørup:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > --- a/config/meson.build
> > +++ b/config/meson.build
> > @@ -379,6 +379,7 @@ if get_option('mbuf_refcnt_atomic')
> >      dpdk_conf.set('RTE_MBUF_REFCNT_ATOMIC', true)
> >  endif
> >  dpdk_conf.set10('RTE_IOVA_IN_MBUF', get_option('enable_iova_as_pa'))
> > +dpdk_conf.set10('RTE_MBUF_HISTORY_DEBUG',
> > get_option('enable_mbuf_history'))
> 
> Not really important, just a suggestion:
> The mempool library has its debug options defined in /config/rte_config.h.
> For consistency, the mbuf history debug option also belongs in /config/rte_config.h, instead of being a meson option.
> It also means using "#ifdef RTE_MBUF_HISTORY_DEBUG" instead of "#if RTE_MBUF_HISTORY_DEBUG".

Yes I was thinking about it.
The separation between rte_config.h and meson_options.txt is not clear.
The idea was to keep the list of Meson options short.
But I think we should make more options visible to most users.

The first thing I will fix in the next revision
(after removing this option from Meson)
is to better document the mbuf debug options.

In future we should create a single debug option in Meson for simplicity.
I think about such a Meson option to enable some debugs selectively:
	debug=assert,dma,rcu,mempool,mbuf-sanity,mbuf-history,flow