From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 5EBAB1B282
 for <dev@dpdk.org>; Wed,  8 Nov 2017 15:22:43 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id E07A020DCE;
 Wed,  8 Nov 2017 09:22:42 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Wed, 08 Nov 2017 09:22:42 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=AtNt1OxadEbwOw1tVGoSG3HFBF
 reyMvaC6rPrtUkQdM=; b=Qj8Yyv0452Yek0TkRN3B6SHY4a3iUzT1cmaQqrSA9E
 4mfycwdQr5Nk6+p+964m1zPQlC9KC49Qfdw+ON6xJOhDdgbif6vlJaCyOvnL/Tem
 M1hQPCQ2k3r76sJNb6BJZLNTz2wAASGMmbKyMILcG4/xzGFIrmUFoeYXMvghly5V
 Q=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=AtNt1O
 xadEbwOw1tVGoSG3HFBFreyMvaC6rPrtUkQdM=; b=AdAFLMa8QXV003COk9TYYN
 g0p2Kqy4aPkru/rK/C+3pQy+h42RtZJQgix9QWvXGNlWIlnKBmcOiNDRU5Qv3NFD
 5oHYIAioiAODD9KpHk0i5M+7wNNxW87LFujcuaWpo6U2G3kDogCRfRH4Y7aSSxtT
 tR1xDXmEqw3ip69c6kksKtI74ZewRYk25hgdpGlYxohLbMaofWwtc/U05K7KGoqy
 zbTfWccWNhsONo8gPlABHr3HJrDFquUO6u6p5TnvI4B5XteFT8xPGe/vjVK4hIu+
 yzZFbADXsV6rkhcL0pmy4afGncy1V+o2EFnxyJX+AjKKgmTKt9lspEj02Luj2JvA
 ==
X-ME-Sender: <xms:MhMDWvL_-BtlXvUA83VKyO1EPOnVcehdve8NipbylIih9UyGlT5-xg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 9E8A07F8F7;
 Wed,  8 Nov 2017 09:22:42 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Radu Nicolau <radu.nicolau@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, wenzhuo.lu@intel.com,
 konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com
Date: Wed, 08 Nov 2017 15:22:41 +0100
Message-ID: <14408406.FDyP0s16KU@xps>
In-Reply-To: <1510147619-8701-1-git-send-email-radu.nicolau@intel.com>
References: <1510147619-8701-1-git-send-email-radu.nicolau@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] doc: added inline crypto feature
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Nov 2017 14:22:43 -0000

Hi,

08/11/2017 14:26, Radu Nicolau:
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -900,6 +900,23 @@ Documentation describes performance values.
>  See ``dpdk.org/doc/perf/*``.
>  
>  
> +.. _nic_features_inline_crypto_doc:

This anchor seems useless.

> +
> +Inline crypto
> +-------------
> +
> +Supports inline crypto processing (eg. inline IPsec). See Security library for more details.

As there are several types of inline crypto, don't you think it deserves
several separate features?