From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id 719F05A4F for ; Tue, 1 Sep 2015 03:58:58 +0200 (CEST) Received: by pabzx8 with SMTP id zx8so158045925pab.1 for ; Mon, 31 Aug 2015 18:58:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lvNaeUdVq+AWIvzCWmSkx3bnXZfeckz/Io3B4JgKB4M=; b=IM2sLuVvSvwaphFp708Eg+JFz3YHtnMo3ZWIDXUHEzKSf9sJPzzyR0tUaPr5oe2iMx 9PihRX75w3uKYznB+ESCjwTLZzbpcWYkjn67x79ML3QpTqVhNAUPj6E5DFWGcE0P4rxc k3xO0yrEMYswBq9s/k1gm1b+ZuU+/Ix5Gr/DUM4pJCVtUxUnGWNs4n5m0RphYaEGu/Jv SpsYyv9CqqUqTynr9rUCJLZatWCdUrfLzDA+DRKMWtjInPW43cxRk38HAV+0GBESGUOh sXJimQkhoKQ73wk0LTbepFUBdWgyYSOMit+KvyaWWJbSQK/uJ2mYMoma/1/HvFI5Nl/E oW3Q== X-Gm-Message-State: ALoCoQnX9C1bGpJNt9Hagcs+wpRO515wmXPE9iqsstXC+vSrhi7cIbetPM2dO4GBIS0Rgdhnnarb X-Received: by 10.66.193.132 with SMTP id ho4mr43279581pac.154.1441072737850; Mon, 31 Aug 2015 18:58:57 -0700 (PDT) Received: from urahara.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id ld8sm15988418pbc.61.2015.08.31.18.58.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 31 Aug 2015 18:58:57 -0700 (PDT) From: Stephen Hemminger To: cristian.dumitrescu@intel.com Date: Mon, 31 Aug 2015 18:59:02 -0700 Message-Id: <1441072746-29174-2-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1441072746-29174-1-git-send-email-stephen@networkplumber.org> References: <1441072746-29174-1-git-send-email-stephen@networkplumber.org> Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH 1/5] examples_ip_pipeline: fix typo's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2015 01:58:58 -0000 Coverity found these as dead-code and/or copy-paste bugs. Signed-off-by: Stephen Hemminger --- examples/ip_pipeline/config_parse.c | 2 +- examples/ip_pipeline/config_parse_tm.c | 2 +- examples/ip_pipeline/pipeline/pipeline_flow_classification.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/ip_pipeline/config_parse.c b/examples/ip_pipeline/config_parse.c index c9b78f9..6b651a8 100644 --- a/examples/ip_pipeline/config_parse.c +++ b/examples/ip_pipeline/config_parse.c @@ -2238,7 +2238,7 @@ save_pipeline_params(struct app_params *app, FILE *f) } /* msgq_out */ - if (p->n_msgq_in) { + if (p->n_msgq_out) { uint32_t j; fprintf(f, "msgq_out ="); diff --git a/examples/ip_pipeline/config_parse_tm.c b/examples/ip_pipeline/config_parse_tm.c index cdebbdc..84702b0 100644 --- a/examples/ip_pipeline/config_parse_tm.c +++ b/examples/ip_pipeline/config_parse_tm.c @@ -399,7 +399,7 @@ tm_cfgfile_load(struct app_pktq_tm_params *tm) memset(tm->sched_subport_params, 0, sizeof(tm->sched_subport_params)); memset(tm->sched_pipe_profiles, 0, sizeof(tm->sched_pipe_profiles)); - memset(&tm->sched_port_params, 0, sizeof(tm->sched_pipe_profiles)); + memset(&tm->sched_port_params, 0, sizeof(tm->sched_port_params)); for (i = 0; i < APP_MAX_SCHED_SUBPORTS * APP_MAX_SCHED_PIPES; i++) tm->sched_pipe_to_profile[i] = -1; diff --git a/examples/ip_pipeline/pipeline/pipeline_flow_classification.c b/examples/ip_pipeline/pipeline/pipeline_flow_classification.c index 4b82180..24cf7dc 100644 --- a/examples/ip_pipeline/pipeline/pipeline_flow_classification.c +++ b/examples/ip_pipeline/pipeline/pipeline_flow_classification.c @@ -442,7 +442,7 @@ app_pipeline_fc_add_bulk(struct app_params *app, flow_rsp = rte_malloc(NULL, n_keys * sizeof(struct pipeline_fc_add_bulk_flow_rsp), RTE_CACHE_LINE_SIZE); - if (flow_req == NULL) { + if (flow_rsq == NULL) { rte_free(flow_req); rte_free(new_flow); rte_free(signature); -- 2.1.4