Re: [dpdk-dev] [PATCH v5 1/4] log: move private functions

[Thomas Monjalon <thomas@monjalon.net>]

06/04/2021 13:28, David Marchand:
> On Mon, Apr 5, 2021 at 9:30 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > Some private log functions had a wrong "rte_" prefix.
> >
> > All private log functions are moved from eal_private.h
> > to the new file eal_log.h:
> >         rte_eal_log_init -> eal_log_init
> >         rte_log_save_regexp -> eal_log_save_regexp
> >         rte_log_save_pattern -> eal_log_save_pattern
> >         eal_log_set_default
> >
> > The static functions in the file eal_common_log.c are renamed:
> >         rte_log_save_level -> log_save_level
> >         rte_log_init -> log_init
> 
> + rte_log_lookup -> log_lookup
> + __rte_log_register -> log_register

I'm worried because this is what I have in my local git tree:

    All private log functions are moved from eal_private.h
    to the new file eal_log.h:
    	rte_eal_log_init -> eal_log_init
    	rte_log_save_regexp -> eal_log_save_regexp
    	rte_log_save_pattern -> eal_log_save_pattern
    	eal_log_set_default
    
    The static functions in the file eal_common_log.c are renamed:
    	rte_log_save_level -> log_save_level
    	rte_log_lookup -> log_lookup
    	rte_log_init -> log_init
    	__rte_log_register -> log_register

I wonder what else is not reflected in this v5 compared to my tree.