From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF84CA0546; Tue, 6 Apr 2021 14:08:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CB53406A2; Tue, 6 Apr 2021 14:08:44 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 34B1C4067C for ; Tue, 6 Apr 2021 14:08:43 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 95F985C00B5; Tue, 6 Apr 2021 08:08:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 06 Apr 2021 08:08:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= byTRPPMuXgi0HASvaJoO/Qe5SZR++BI0fLj+01Fq5Aw=; b=saDfFkT1+vGXheUN mVS4KvIadzXIlT9MvJ6Dqll7WDPC43OmfT1kdnsWDlAMrf+s0ZoafEpFCo1sklsu u9Q8V7OkSYWHWB5xWQg68m0xmXq5SwldLSWLNtKt90ZpkzYhr8JIQ0Oe8kH3PrHZ l9IMevuIxOaafBNfX3GuKJAj8pjYYX5h1Cq9w7x5o4jwDOTmcjaw2kkavbcPE8hM d2urXhBJXZlRRZrC+vbVeWvjZKFErWMK/2ttPPIgDK/3IQPaSIh3KglG7RgH11B8 2VbrNm7NLGf3Qv4KClcyW/sER7FYtcFZiWCow5gCYM5vgwnKwnLHv9bysgUW5hBw 3J/Ujw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=byTRPPMuXgi0HASvaJoO/Qe5SZR++BI0fLj+01Fq5 Aw=; b=B3ALBIcKjpKXn6hD8KIxWHSg82xBLj518yY8rBQ1nJhERQRbU/Jx60rFG qG6sryjULR9LrhTbh7iWvDa8ZgHkKNtSyWYw03FB8tWEL2ztFOrmKImfWqyH+RAH 5d5tH5kiJiCTR9rslfev1ThBxljalg5GdvYZVeRIVkfoIdP22CW4OXXBJvKgqjVJ cft2sh1JtIdSAisWLPexbSVsqsdh0X9iBQGnjWY8gxspif+QY9WU4weYsZWTG1KV jiDas5+IfNszZDATk2oFBIe/M2PFJAYNUv6bghoY2yIimPuoePKVV5BTsTIJG2sW O3Kt8dVK0Pm8lslkxypYjUbM6oQmg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejgedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 772021080063; Tue, 6 Apr 2021 08:08:40 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev , Bruce Richardson , Andrew Rybchenko , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Date: Tue, 06 Apr 2021 14:08:37 +0200 Message-ID: <14445126.lWDQrp9GDp@thomas> In-Reply-To: References: <20210309233116.1934666-1-thomas@monjalon.net> <20210405193000.1113542-2-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/4] log: move private functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/04/2021 13:28, David Marchand: > On Mon, Apr 5, 2021 at 9:30 PM Thomas Monjalon wrote: > > > > Some private log functions had a wrong "rte_" prefix. > > > > All private log functions are moved from eal_private.h > > to the new file eal_log.h: > > rte_eal_log_init -> eal_log_init > > rte_log_save_regexp -> eal_log_save_regexp > > rte_log_save_pattern -> eal_log_save_pattern > > eal_log_set_default > > > > The static functions in the file eal_common_log.c are renamed: > > rte_log_save_level -> log_save_level > > rte_log_init -> log_init > > + rte_log_lookup -> log_lookup > + __rte_log_register -> log_register I'm worried because this is what I have in my local git tree: All private log functions are moved from eal_private.h to the new file eal_log.h: rte_eal_log_init -> eal_log_init rte_log_save_regexp -> eal_log_save_regexp rte_log_save_pattern -> eal_log_save_pattern eal_log_set_default The static functions in the file eal_common_log.c are renamed: rte_log_save_level -> log_save_level rte_log_lookup -> log_lookup rte_log_init -> log_init __rte_log_register -> log_register I wonder what else is not reflected in this v5 compared to my tree.