From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79E9342DAE; Tue, 4 Jul 2023 16:40:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01AE440E03; Tue, 4 Jul 2023 16:40:18 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2088.outbound.protection.outlook.com [40.107.93.88]) by mails.dpdk.org (Postfix) with ESMTP id 78DCF40042 for ; Tue, 4 Jul 2023 16:40:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E3t9MOMGhB0+IznwuYGfV7ASnqkEmdAvTpXga3qxwSbfNidrSBYugiCCFHM+mE6UVeYZ/4kHc/uX3ocflaCNrPWRwq5/vhwXWzesFN3R7C2GIZcgUay0b6KN5HnkGUFnRVP8ERnLg0KouGGyOrLQBPthQ263OVZIuyCqXIFw2hKPRUbHw8LH7gNql6MSzItFiqmO6lCyx/gP6nNIjXMah5/rDBMGi7JD4Ohz2j4MrSctbQ6M7sObKGpX7pzaJTABbyp8gf5nFwjcnrGWekhCTfWtbralN/HyCE6zz7N8tL6WHmQFr9j6I/ciLLlDo6ZFvzbM+w928A6vaBy7wi71FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eu+mxeA/cvFAUDXuX/EvNtwihrT0dx5SkIujlzBHjGE=; b=TaEUGAklb7hpAoj6bMDxr9YSNiRrnN5Uz/OuYIoZJkoToMPDkU9Hey3qwscHfq1l4DRDgNqCpV8kjAcRmm3PCMFRa4BCCa/cqC7HdoA/FA1++GAxfeoXsUz2xCNSoDjWa+XM8SDrRpfpu6ACM8MAmx4jLrzqx7tGHkre4+O51iyGXqKQy0qcPHvzQB18BfWo7pS7iRbx08N+5FoKJOLHw4H1N/ZWPA7XtVJhiRBI3K/69gBwnhHEGWDR0y7ijSG4ONi6xfC9TpkUdrOGuupQNX2yK7B2J+FZu7ebcMdAse27G8cMfBZrdzvCSXWSWISYbIsjbvtCRNK0v+0laiv3og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eu+mxeA/cvFAUDXuX/EvNtwihrT0dx5SkIujlzBHjGE=; b=jNDcjl3xrvsijfQykvt/vI65AIjjC8fiX75Y8O2yXvot299WPP4nQ90zPGCnKRQDxiB3s2a5McHYjgte5OauNQVo518EFJGDxi2r5APSLoavDU30DlN/K2IsVHkdBaxj5A9EtenvvCc6Rh/U4QX9Uo7RXi4yQDUuzIk2UtjKk94= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW4PR12MB6874.namprd12.prod.outlook.com (2603:10b6:303:20b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Tue, 4 Jul 2023 14:40:14 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 14:40:14 +0000 Message-ID: <1444ce81-5369-49bd-4e50-bb536a446931@amd.com> Date: Tue, 4 Jul 2023 15:40:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH V2 2/2] app/testpmd: assign custom ID to flow rules Content-Language: en-US To: Ori Kam , Gregory Etelson , "dev@dpdk.org" Cc: Eli Britstein , Asaf Penso , Thomas Monjalon , Aman Singh , Yuying Zhang References: <20230222141139.3233715-2-elibr@nvidia.com> <20230316141934.23181-1-getelson@nvidia.com> <20230316141934.23181-2-getelson@nvidia.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0001.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:338::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW4PR12MB6874:EE_ X-MS-Office365-Filtering-Correlation-Id: 7fa8f7ca-0ad0-4d2e-a7ef-08db7c9c93e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dq1Ve7rkJXgr2HV6CrfhW/Ex1td10OoJBPaqan/MqHKYaiue5Ek0isUfvcxd5M5/CchPRCG2VBmWv/d3F19klsYYqc+kpuJmT1ZKY2wA6j+Fg4VSBUvW12gze6NuVojxcA7LrJwdysHC20sbBIa59FRbJMXYEHM31WeZ8rXNix8SEu+IEtty2JCbALp/kjvkBl6Km9+rynRrpWcbBevwlctx/cHXUo+vp3PRX1NgeYyTv5iYqOG1oVypN6lhc4pz4YtfrQyk8DB4EXbW3RGTnIq1LhYn08HD2fJv81cjZWEhmBO03OqXvIB8npwqu1E67t8tkqnlw6Yhe+REQAAO0mxv4nVXPot/WxBvbNuz8vear7IZX7/nbTDyBa7a7nL9mr18UCXmrMu5wZ6/lf0CQLwIXY2TJeYxVW+29hKiiUKDfsFT2H5X6wMXd9yO4u/A26swUyv5bQCywIHkyhkbONvGTqn9WSTH3oNJ9jlnxmP2D0wXXwqWYuGqTakeji9sYPqSBi/wPq2Sje6RzpQdBb1TflLWgBR6sZrihmg4It2zWGTY5PEiWH0B3/EAKOo8m3WtruystHcSRnxbBEvqWZbGdWgF0yDzcn2yD3HTGMsNuTjt966m+5WaVr8LwIJh9yNM6QpZLqk4BOzjh/BELw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(136003)(396003)(346002)(366004)(39860400002)(451199021)(31686004)(6666004)(6512007)(6486002)(54906003)(110136005)(478600001)(83380400001)(2616005)(36756003)(31696002)(86362001)(2906002)(53546011)(26005)(186003)(6506007)(38100700002)(66946007)(66556008)(66476007)(44832011)(4326008)(316002)(5660300002)(41300700001)(8936002)(8676002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEZaZEs3cC9pSUY1a1h2UTU5MTVYeEdDMHU3dmFCbVhSb0pjY0tsRGpQbDAr?= =?utf-8?B?MDEvQThwQkxxeVZCb3h2MFJjZCtvdzROZGpEb3doYWFuQTM1Q2pZRjBvUzJn?= =?utf-8?B?MVlXamVzSmdHaWg5OFF0ZmFXV2cySHAxRzBDbU9EYWlJQ2Z5OWtPTGxVQ0Vw?= =?utf-8?B?NnNLSDFDVVhWMWVGRGFvckFsUmRrdlZ5QkRVVXR2bXRoRkxpcFlzT213TitK?= =?utf-8?B?aU1GRGFSWkhEUHRaRkpYd0l6M2NjcTlDV29DcENsSTVIcVJpQlhHU0xqTEU4?= =?utf-8?B?Rno0RHFPNEQyZyttTjUzUW90Wjh2b2VQakE2QWpBVld4SzV5cy9qTm5PeTBx?= =?utf-8?B?T1ZXa29EWm5XNTlmUG1OMnN6S2tRUllXbjdubmI3R3BUdEw4K2JRZ0hhSS9M?= =?utf-8?B?S1FmSzNBMUFsOVlCNDFzQW93bzZyL0ptWEtQOWd4VC9zampVa0xtVk41K3l2?= =?utf-8?B?WjRuekJGblVmNmdmN2NCckFoZDNQRWhyd1gzVU50RERBKzZEN3pYdUJBYVBv?= =?utf-8?B?RVRsaDlCWWl2Vi9XNXZwb1dIS3UvZElQRzF2Q1ArMW01MjBORU9wNTdaalJE?= =?utf-8?B?UzNWbGdWTGdITTB1T3RqRTVib0lUQ1MzelJCNGZ4bHF4eXk3R1M2Y1E0UHBr?= =?utf-8?B?eEJ1cTdxdTdzSjBCd2MwTlE1dm1MRVdHRlZHTDJZc3hFbFJEYS9tK0g2aGI5?= =?utf-8?B?SUpYWHhuNk1hcCt6Mmd2bnphN2kxWVBCUWdlamw4bWpLS0lIYTV0S1VLZnhw?= =?utf-8?B?dmdiTkR1QnJUSlEyZlhsVVZZbWd2U1RYdUxweW1OTTJ2Y0hNZVlNbXNoQ1ZT?= =?utf-8?B?enc1WDBxKzg4OVJjclZsaW1GT0VySmZySWhqRTVPZ0xLZS9ET0NFT0VvaFl1?= =?utf-8?B?NU85dDZnM1AvUzNpaWZ6R2NtNXRrUzBSbnd5eUN3QzYxV2kxZGFMUzM0Uy9C?= =?utf-8?B?Z243d0pHbUNoNm1LR25iRHozZUlEUGhmeW8rMFpnd2hFaUFZNWdHN1lhcGlS?= =?utf-8?B?cnZYYWhneDArNUVvQ2pIN2xOYWV3S0VMY1diK3djaTVZb0czMllXdWlhQWNW?= =?utf-8?B?QmFrbFdqakl3cHFSdCtoVDhsalh3VENGQTFlNjhsMm9QMjFyaGh6a1cyOHJE?= =?utf-8?B?MmJOR1RydGV2eFAzMjFZQ1hHcmMvYk1xWmZ3NXByc3F6UnZobGNtUzh1TTJM?= =?utf-8?B?M2tOVHpVUzA0SWRDa0J4aUhESk8ranhjZUR3bTdGRVpRUDVKeGRPdjc4YmtF?= =?utf-8?B?a2Z2blk5NVhxV2ZIbStRejZiMWpBcWxDamxyTFVsYTVpZW5SNStYZmVwTkVX?= =?utf-8?B?THhqeTJqa3RwQUw4emlwaUx1Tm90RHFvVUpjT2RzNTNaMkFWK3VLaUdCVzhT?= =?utf-8?B?Qm9iZ3JIZHBFQndHVzFMQVdOSVI3N0ZibWc5MGQybklrWTZ4eTUvaEZQNkI5?= =?utf-8?B?c2kycnN3K3V0UW9VemlPZGNKTEgzaEFoRHdPOGI4b20xbzhmajk0SXduSit0?= =?utf-8?B?cWlJM3dYNXFzRUd0ck5BdVFIYUxLdzJEOEZ4djBXRUlHNVYreEdJamJkNEhL?= =?utf-8?B?VVliTDVWOFpYbldZQVNITGUyRndJM29XbzVNZUVZMmpOUldwbG5SUURsWFhi?= =?utf-8?B?bmdBc2tRM0FqbElIakoyR2lDYkMvdlNveG43SmpSS3o1dlFzYkVJcUZudkxi?= =?utf-8?B?RXdGdWRubHlmdCtLVnBEMzhlcU5OK1cxejR3Ri9CamxRVVhjc0wxcFQ2c3Bk?= =?utf-8?B?eHRtWjU3MGp0U1BFNWNCRnZIT0R5MWh2MnBaUGE4Zjd0Q2FvTjg2cjA4MTFN?= =?utf-8?B?YjU4T3BtYnZYNFpzRGp6WkhRY1FGNmZmdXNiQ3YyMXlBZlkweUVvam8wZm5S?= =?utf-8?B?SExnN2M2ZHFyMm04WnJwL2p3bU5SdEp5dkpMK2dZMXpZdzIrOWlkUHRHZTVD?= =?utf-8?B?Wms5Y0hZaW9nOFJnYnAxcEtIazZlZjhFQ09PNjRTdlM0MzF1OUdVcGsxRHZ1?= =?utf-8?B?TjN3V1gwRzE4SlhBK0Q2QUlPN1VtT2tjSlMrcE1tRzRWcEprOUFQaWNaOWh5?= =?utf-8?B?Z0I1aE1DYjgyS2FEaFkxeDM0SXVDOVlJR1JhVUgxTGVjekNHYTlMalpzeHNz?= =?utf-8?Q?oSjeBkTJZ/veJTgTkBGEgfkS+?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fa8f7ca-0ad0-4d2e-a7ef-08db7c9c93e0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 14:40:14.2769 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: spQlZy11gsahJl1NC/662sp2nWtBhzup9Icc7QDi+9dBUM1Nvfvf/9jFdyFy9eSN X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6874 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/4/2023 9:25 AM, Ori Kam wrote: > > >> -----Original Message----- >> From: Gregory Etelson >> Subject: [PATCH V2 2/2] app/testpmd: assign custom ID to flow rules >> >> From: Eli Britstein >> >> Upon creation of a flow, testpmd assigns it a flow ID. Later, the >> flow ID is used for flow operations (query, destroy, dump). >> >> The testpmd application allows to manage flow rules with its IDs. >> The flow ID is known only when the flow is created. >> In order to prepare a complete sequence of testpmd commands to >> copy/paste, the flow IDs must be predictable. >> >> Allow the user to provide an assigned ID. >> >> Example: >> testpmd> flow create 0 ingress user_id 0x1234 pattern eth / end actions >> count / drop / end >> Flow rule #0 created, user-id 0x1234 >> >> testpmd> flow query 0 0x1234 count user_id >> >> testpmd> flow dump 0 user_id rule 0x1234 >> >> testpmd> flow destroy 0 rule 0x1234 user_id >> Flow rule #0 destroyed, user-id 0x1234 >> >> Here, "user_id" is a flag that signifies the "rule" ID is the user-id. >> >> The motivation is from OVS. OVS dumps its "rte_flow_create" calls to the >> log in testpmd commands syntax. As the flow ID testpmd would assign is >> unkwon, it cannot log valid "flow destroy" commands. >> >> With this enhancement, valid testpmd commands can be created in a >> log to copy/paste to testpmd. >> The application's flows sequence can then be played back in >> testpmd, to enable enhanced dpdk debug capabilities of the >> applications's flows in a controlled environment of testpmd >> rather than a dynamic, more difficult to debug environment of the >> application. >> >> Signed-off-by: Eli Britstein >> --- > > Best, > Acked-by: Ori Kam > Series applied to dpdk-next-net/main, thanks.