From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CCD0A0524; Thu, 29 Apr 2021 09:57:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84AF9406B4; Thu, 29 Apr 2021 09:57:58 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 683E740141 for ; Thu, 29 Apr 2021 09:57:57 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1AF965C008F; Thu, 29 Apr 2021 03:57:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 29 Apr 2021 03:57:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= DeuTiBYd2zF+EvGo2YGC4CWjqmzU9LZgxOF2XPKbDP0=; b=frz5qZJUXzghWVR0 1uEM7swY95wTvPmMxIFmSr7FhyIAfIpcTgKDWu/t9ZxDH8CkbcexcRhTXZWACAV4 w8pl+anB4MNwCcEBC46pU2zfklaIF/x0NyYFS1307JB1asG8USQxsL/k1ipstP40 Vk+S3nGZ0MBHgXXMscGM5buCibaBMsbPQdT8uaC1nS881KCP6KQXf7XCnEsITpS+ sKXIqwyYrXuliltvUOxfsIlhHv81O+AgrbMyb3xicHssOEvpTluFv9q/iSOU39K8 NVt4D15M7T8IB43s80Am8k+IXYTjrdmjT6+nYVbMFZ36CHo+dUb9xptcTJ0n/hk1 iBYC7w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=DeuTiBYd2zF+EvGo2YGC4CWjqmzU9LZgxOF2XPKbD P0=; b=ayBrHDx8VO2IRGFNHw6DjfjAIw6KBKWhbtz0fokM5kG2tWr6gtf1puAcq SA3N8jwTPQ9rvOfddHF/YO8s6dj9LehnJIi2l8HWGR73JDyrQ2tYdps3ZoBgSJL2 C1S3zEMGOEuxiLoc3C6GPjzzNUPDdYgxeTRyOuSBCHVR300IkXeLNtT/rd+7bVlx 3eAS7fxA6nVNDQMWBXUIn5XjPoOCoKJzWXHXKp0pDDS+yGWghxRG/2Qvhk8Tsm6p x1wf6Z/ELtf16VX0mIolBsv7rXDt8ZSUP5MnEce2qAtp0qQoLUQu6BSukB4OT4Na 1JiZnXM1gMcmRvhWVq+p7Lp7siA6A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddvfedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Apr 2021 03:57:55 -0400 (EDT) From: Thomas Monjalon To: Gregory Etelson Cc: dev@dpdk.org, matan@nvidia.com, orika@nvidia.com, rasland@nvidia.com, Viacheslav Ovsiienko , Ferruh Yigit , Andrew Rybchenko , Ajit Khaparde , asafp@nvidia.com Date: Thu, 29 Apr 2021 09:57:54 +0200 Message-ID: <14463652.88Pjyj3dRd@thomas> In-Reply-To: <20210429061634.3481-2-getelson@nvidia.com> References: <20210428175906.21387-1-getelson@nvidia.com> <20210429061634.3481-1-getelson@nvidia.com> <20210429061634.3481-2-getelson@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: fix integrity flow item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/04/2021 08:16, Gregory Etelson: > Add integrity item definition to the rte_flow_desc_item array. > The new entry allows to build RTE flow item from a data > stored in rte_flow_item_integrity type. > > Add bitmasks to the integrity item value. > The masks allow to query multiple integrity filters in a single > compare operation. > > Fixes: b10a421a1f3b ("ethdev: add packet integrity check flow rules") > > Signed-off-by: Gregory Etelson > Acked-by: Viacheslav Ovsiienko > --- > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > +#define RTE_FLOW_ITEM_INTEGRITY_PKT_OK RTE_BIT64(0) > +#define RTE_FLOW_ITEM_INTEGRITY_L2_OK RTE_BIT64(1) > +#define RTE_FLOW_ITEM_INTEGRITY_L3_OK RTE_BIT64(2) > +#define RTE_FLOW_ITEM_INTEGRITY_L4_OK RTE_BIT64(3) > +#define RTE_FLOW_ITEM_INTEGRITY_L2_CRC_OK RTE_BIT64(4) > +#define RTE_FLOW_ITEM_INTEGRITY_IPV4_CSUM_OK RTE_BIT64(5) > +#define RTE_FLOW_ITEM_INTEGRITY_L4_CSUM_OK RTE_BIT64(6) > +#define RTE_FLOW_ITEM_INTEGRITY_L3_LEN_OK RTE_BIT64(7) I still have the same comment as in v1: we are missing an API comment to reference the bits RTE_FLOW_ITEM_INTEGRITY_* where it should be used.