From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 50BBC8E80 for ; Tue, 3 Nov 2015 21:13:53 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 03 Nov 2015 12:13:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,239,1444719600"; d="scan'208";a="810971102" Received: from sie-lab-214-036.ir.intel.com (HELO sie-lab-214-174.ir.intel.com) ([10.237.214.36]) by orsmga001.jf.intel.com with ESMTP; 03 Nov 2015 12:13:49 -0800 From: Pablo de Lara To: dev@dpdk.org Date: Tue, 3 Nov 2015 20:13:48 +0000 Message-Id: <1446581628-133217-1-git-send-email-pablo.de.lara.guarch@intel.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1446580605-131889-1-git-send-email-pablo.de.lara.guarch@intel.com> References: <1446580605-131889-1-git-send-email-pablo.de.lara.guarch@intel.com> Subject: [dpdk-dev] [PATCH v2] l3fwd: fix lookup burst size for ipv6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 20:13:53 -0000 Lookup burst size was changed for exact match from 4 to 8, for both ipv4 and ipv6, but actually only 4 keys were being looked up for ipv6, instead of 8, causing random segmentation faults. Fixes: 80fcb4d4 ("examples/l3fwd: increase lookup burst size to 8") Signed-off-by: Pablo de Lara --- Changes in v2: - Include update in release notes doc/guides/rel_notes/release_2_2.rst | 4 ++++ examples/l3fwd/main.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst index b39a78a..0172354 100644 --- a/doc/guides/rel_notes/release_2_2.rst +++ b/doc/guides/rel_notes/release_2_2.rst @@ -143,6 +143,10 @@ Libraries Examples ~~~~~~~~ +* **l3fwd: fix lookup burst size for ipv6.** + + Fixed issue where app crashes if ipv6 is used, due to a wrong + lookup burst size. Other ~~~~~ diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 1f3e5c6..74703b0 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -1005,7 +1005,7 @@ simple_ipv6_fwd_8pkts(struct rte_mbuf *m[8], uint8_t portid, struct lcore_conf * const void *key_array[8] = {&key[0], &key[1], &key[2], &key[3], &key[4], &key[5], &key[6], &key[7]}; - rte_hash_lookup_multi(qconf->ipv6_lookup_struct, &key_array[0], 4, ret); + rte_hash_lookup_multi(qconf->ipv6_lookup_struct, &key_array[0], 8, ret); dst_port[0] = (uint8_t) ((ret[0] < 0) ? portid:ipv6_l3fwd_out_if[ret[0]]); dst_port[1] = (uint8_t) ((ret[1] < 0) ? portid:ipv6_l3fwd_out_if[ret[1]]); dst_port[2] = (uint8_t) ((ret[2] < 0) ? portid:ipv6_l3fwd_out_if[ret[2]]); -- 2.4.3