From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id CCF038E56 for ; Wed, 4 Nov 2015 16:51:18 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 04 Nov 2015 07:51:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,243,1444719600"; d="scan'208";a="843025096" Received: from sie-lab-212-222.ir.intel.com (HELO silpixa00366884.ir.intel.com) ([10.237.212.222]) by fmsmga002.fm.intel.com with ESMTP; 04 Nov 2015 07:50:55 -0800 From: Harry van Haaren To: dev@dpdk.org Date: Wed, 4 Nov 2015 15:50:30 +0000 Message-Id: <1446652230-10009-1-git-send-email-harry.van.haaren@intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <5639CB88.7040108@allegro-packets.com> References: <5639CB88.7040108@allegro-packets.com> Subject: [dpdk-dev] [PATCH] ixgbe: remove l3_l4_xsum_errors from rx errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2015 15:51:19 -0000 This patch removes l3_l4_xsum_errors from rx errors. The reason to remove it is that UDP packets have an optional checksum, and when not calculated the checksum field should be set to zero. When the checksum is not calculated (zero-ed out), the hardware still counts a valid UDP packet as an l3_l4_xsum_error. This hardware issue is documented in 82599 errata, titled: "Integrity Error Reported for IPv4/UDP Packets with Zero Checksum" The solution is to remove l3_l4_xsum_errors from rx_errors, as discussed on http://thread.gmane.org/gmane.comp.networking.dpdk.devel/25590/ Suggested-by: Martin Weiser Signed-off-by: Harry van Haaren --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 25966ef..9ed5b49 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -2480,7 +2480,6 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) total_missed_rx + hw_stats->illerrc + hw_stats->errbc + - hw_stats->xec + hw_stats->rfc + hw_stats->fccrc + hw_stats->fclast; -- 1.9.1