From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id F12111B1C8 for ; Fri, 16 Feb 2018 14:00:37 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7018C20A9E; Fri, 16 Feb 2018 08:00:37 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 16 Feb 2018 08:00:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=1L+l/xxSHYekdgf5fUG+ntXj+w D65z9aCUAHCqS/dWA=; b=Rk1EwF9JsRWjnz7lgHVU9vcGvY6CexHR6mApcx+MZc 1iS17q8gZd5hrV+CnAJJyaltJ1rcst2PmZ1PIzOaEECcS8+SFTV5OIOIDsVLDOSn 5JWg90JSaqGffX1b1ZjYFcveLzztL/8IrnVLMKBgKJ2+wil7wiEkWRL4zYPa4mxx Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=1L+l/x xSHYekdgf5fUG+ntXj+wD65z9aCUAHCqS/dWA=; b=cGfkaWAT4xdvP/Td6ko594 EFz/ykSo+v8gFE1Vd7fyqSL/iBOwPpNo7KiTnwqyRVtwEHTJezyhN+hDCEO2z4l5 erWrgjN0AKy9FJnl6sJ1jBWTi9RU1ZjTMUbmkPRBPxMKnRwCqswUPKy47NIXUNCy CdvLMAhNaF1zjV/40S2utkCW3uIeTKGMzhYAZrNnIEyqUdH8A4LVzYJzdJtNAG/A Baugez126BLqQrBPEyIystfQkWVEeL97m5gqr+Cg9PDoSqclOnLpkRqJkg6vHoXL I58Fk7zUqYEitBIvGotSn6mm471qq3aBGykeSlCMmRjgNTHP9bC7qjs9QASgYvVw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 215DB7E4A8; Fri, 16 Feb 2018 08:00:37 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: Ophir Munk , dev@dpdk.org, Pascal Mazon , Olga Shern Date: Fri, 16 Feb 2018 14:00:21 +0100 Message-ID: <14471929.PddjlPaB1B@xps> In-Reply-To: <20180215135558.78f2e0ca@xeon-e3> References: <1518509665-12171-1-git-send-email-ophirmu@mellanox.com> <4788233.rokdTfvtAd@xps> <20180215135558.78f2e0ca@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] net/tap: add CRC stripping capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Feb 2018 13:00:38 -0000 15/02/2018 22:55, Stephen Hemminger: > On Tue, 13 Feb 2018 17:35:20 +0100 > Thomas Monjalon wrote: > > > 13/02/2018 09:14, Ophir Munk: > > > CRC stripping is executed in the kernel outside of TAP PMD scope. > > > There is no prevention that the TAP PMD will report on Rx CRC > > > stripping capability. > > > In the corrupted code, TAP PMD did not report on this capability. > > > The fix enables TAP PMD to report that Rx CRC stripping is supported. > > > > > > Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Ophir Munk > > > > Applied, thanks > > > > The whole CRC strip flag notion is backwards. It really should of been > a bit set if driver allows preserving CRC. > > Since changing the ABI is not possible right now; > the ethdev core ought to log a warning whenever driver is registered > without CRC_STRIP flag. > > Or is lack of CRC_STRIP in offload flags implying that driver can > do strip and not stripping? I agree we should change the API. Let's open a new thread to discuss it with a wider audience.