* [dpdk-dev] [PATCH] l3fwd-acl: fix possible memory leak.
@ 2014-12-16 17:05 Konstantin Ananyev
2014-12-17 0:12 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Konstantin Ananyev @ 2014-12-16 17:05 UTC (permalink / raw)
To: dev
At error app_acl_init() can return without freeing dynamically allocated memory.
Not really a big problem, as if app_acl_init() fails,
then application would terminate immediately anyway.
Though it is a good coding practise to make a function to cleanup after itself.
Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
examples/l3fwd-acl/main.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
index 4487c95..022ccab 100644
--- a/examples/l3fwd-acl/main.c
+++ b/examples/l3fwd-acl/main.c
@@ -1247,6 +1247,10 @@ app_acl_init(void)
acl_log("Socket %d of lcore %u is out "
"of range %d\n",
socketid, lcore_id, NB_SOCKETS);
+ free(route_base_ipv4);
+ free(route_base_ipv6);
+ free(acl_base_ipv4);
+ free(acl_base_ipv6);
return -1;
}
--
1.8.5.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] l3fwd-acl: fix possible memory leak.
2014-12-16 17:05 [dpdk-dev] [PATCH] l3fwd-acl: fix possible memory leak Konstantin Ananyev
@ 2014-12-17 0:12 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2014-12-17 0:12 UTC (permalink / raw)
To: Konstantin Ananyev; +Cc: dev
> At error app_acl_init() can return without freeing dynamically allocated memory.
> Not really a big problem, as if app_acl_init() fails,
> then application would terminate immediately anyway.
> Though it is a good coding practise to make a function to cleanup after itself.
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied
Thanks
--
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-17 0:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-16 17:05 [dpdk-dev] [PATCH] l3fwd-acl: fix possible memory leak Konstantin Ananyev
2014-12-17 0:12 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).