From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f180.google.com (mail-pf0-f180.google.com [209.85.192.180]) by dpdk.org (Postfix) with ESMTP id 756BFDE3 for ; Wed, 23 Dec 2015 09:08:44 +0100 (CET) Received: by mail-pf0-f180.google.com with SMTP id q63so13197218pfb.0 for ; Wed, 23 Dec 2015 00:08:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bigswitch-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=LQJc3WiJHyNgLdb1vHvdS8oxdXjuZj+sQ6Xkgacl/jU=; b=MAIvO41tadXpZ2iFAmeatr5q+sod4Vhu1FtBl05Rf30lyU/G+aleVScXC4OVxtj5of ClF3WiEYGfH+vUmxjtjvkqEC80Ffa1Pi/CoTceMxRLTmqn8mSbC4ijC7RHfevnJBtAsv 1Upikpo6vQLpmj9dnrXh8HHWCa3P8GPCUw0wXO6701xEOzgxu47kw0cCvg0INqNNb/7Z JQkxaxh64e3vbhnhZs2vTeWUjSPDUocXe0tWTcKrN1QLiwpowfAdqBZKeqxksWRzUIm4 9fe0WQUXTv4RgOgb0VrxkuPqt7IWMMiCVuiQVLxAdMdjR0rAjP2V6eXGDCqARV2tbSS2 AUnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=LQJc3WiJHyNgLdb1vHvdS8oxdXjuZj+sQ6Xkgacl/jU=; b=GlVw/Je3Xr00Nqivz+2VVnq1vgsUTSQX5/bUjt+9Mc0ot3JWPBhgZUVO0Bblxq4zVD tJ3V8289rvWNAPZbxMRWgFT/7CQzINnbj1FfVcvW1D+Oedpkkm7dCewjdoyU7ofK2VsO MuO3CkMNbX//BmBOc43QFot1FRSvhdjnWveZsqF1HmcH6cFPkhKwD20YlokmWa8AkKr+ skMGxU418zb+/YAxqHJDOgpyeo5Uk593gDtf9OynPejeWl9Kn/uSno+CuB+V412/LNI0 /bW2KTZBosWYnL1ffSJ6hP+6UeQUKUPLSCQ4q5/1f8h80BlAQ1A2rHPFiLog+qIn+MDu qgSQ== X-Gm-Message-State: ALoCoQkC1/euQgVxzKViBBypTL0kqNgrVCXygym+L1Ta0VkxgIAoqb9pIlVESpSjdDsseG4pvL1T6Pe6h9kAg5wWRkuWn/AZzA== X-Received: by 10.98.11.209 with SMTP id 78mr16062280pfl.64.1450858123705; Wed, 23 Dec 2015 00:08:43 -0800 (PST) Received: from rlane-work.eng.bigswitch.com (c-67-188-28-208.hsd1.ca.comcast.net. [67.188.28.208]) by smtp.gmail.com with ESMTPSA id v68sm45929566pfa.1.2015.12.23.00.08.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 23 Dec 2015 00:08:43 -0800 (PST) From: Rich Lane X-Google-Original-From: Rich Lane To: dev@dpdk.org Date: Wed, 23 Dec 2015 00:08:00 -0800 Message-Id: <1450858080-71465-1-git-send-email-rlane@bigswitch.com> X-Mailer: git-send-email 1.9.1 Subject: [dpdk-dev] [PATCH] i40e: fix inverted check for ETH_TXQ_FLAGS_NOREFCOUNT X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Dec 2015 08:08:44 -0000 The no-refcount path was being taken without the application opting in to it. Reported-by: Mike Stolarchuk Signed-off-by: Rich Lane --- drivers/net/i40e/i40e_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 39d94ec..d0bdeb9 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -1762,7 +1762,7 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq) for (i = 0; i < txq->tx_rs_thresh; i++) rte_prefetch0((txep + i)->mbuf); - if (!(txq->txq_flags & (uint32_t)ETH_TXQ_FLAGS_NOREFCOUNT)) { + if (txq->txq_flags & (uint32_t)ETH_TXQ_FLAGS_NOREFCOUNT) { for (i = 0; i < txq->tx_rs_thresh; ++i, ++txep) { rte_mempool_put(txep->mbuf->pool, txep->mbuf); txep->mbuf = NULL; -- 1.9.1