From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9353FC334 for ; Thu, 28 Jan 2016 08:15:45 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 27 Jan 2016 23:15:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,357,1449561600"; d="scan'208";a="902741862" Received: from dpdk15.sh.intel.com ([10.239.129.25]) by fmsmga002.fm.intel.com with ESMTP; 27 Jan 2016 23:15:41 -0800 From: Huawei Xie To: dev@dpdk.org, thomas.monjalon@6wind.com Date: Wed, 27 Jan 2016 23:21:18 +0800 Message-Id: <1453908082-92036-1-git-send-email-huawei.xie@intel.com> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <20151222035041.GA7532@pxdev.xzpeter.org> References: <20151222035041.GA7532@pxdev.xzpeter.org> Cc: nikita.troitsky@intel.com Subject: [dpdk-dev] [PATCH v3 0/4] fix the issue that DPDK takes over virtio device blindly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2016 07:15:46 -0000 v3 changes: change log message to tell user that the virtio device is skipped due to it is managed by kernel driver, instead of asking user to unbind it from kernel driver. v2 changes: Remove unnecessary assignment of NULL to dev->data->mac_addrs Ajust one comment's position change LOG level from ERR to INFO virtio PMD doesn't set RTE_PCI_DRV_NEED_MAPPING in drv_flags of its eth_driver. It will try igb_uio and PORT IO in turn to configure virtio device. Even user in guest VM doesn't want to use virtio for DPDK, virtio PMD will take over the device blindly. The more serious problem is kernel driver is still manipulating the device, which causes driver conflict. This patch checks if there is any kernel driver manipulating the virtio device before virtio PMD uses port IO to configure the device. Huawei Xie (4): eal: make the comment more accurate eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't manipulating the device. virtio: return 1 to tell the kernel we don't take over this device virtio: check if kernel driver is manipulating the virtio device drivers/net/virtio/virtio_ethdev.c | 14 ++++++++++++-- lib/librte_eal/common/eal_common_pci.c | 8 ++++---- lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +- 3 files changed, 17 insertions(+), 7 deletions(-) -- 1.8.1.4