From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 245E795CA for ; Thu, 11 Feb 2016 00:45:41 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id c200so51545579wme.0 for ; Wed, 10 Feb 2016 15:45:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=k4Qt1BSMVBDDd7AdKKqpFaWCuGhxqudCRTYo6zXAYtE=; b=fB0YqYMfF4NyclHmE4AIojebpfJXUWobReG2yjmPo6THQIQqzt1cb/GzrTpx69it8d F1rhsZdTEBP8gTbsH7ow6vEgM1YUZEgW86wn1ws13I3PskYPgVUSiJgBlJmYfpm3LuUq B+3qkHlNrZR4x0w0tcr3qNp0I1LqPC3Jb6bp0W/D2dTR8sVfiUowPv/Sh3kfOwitHoX3 4kgRzbkRgmD5Z4nNvl54HL7ba3N/hC3E8IQOXJH2y6nOXV5Y++covDEWZzPywuO6CTLV yl3W3JGEspWp1jA6ggAxdgR9sTn5q8zKMHaBS1eboKPdFqXmZi5BN5Cd30mlBW9B+ibQ 8Wmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=k4Qt1BSMVBDDd7AdKKqpFaWCuGhxqudCRTYo6zXAYtE=; b=hcOr230L6qJu0+XURURfyXsijKsSmqVT0G/05KZL/ZK1I64n1FU5EmSrxid6NyVG5/ Vd7tAJ32nJfXCiyiCnyYWAcy34evlFsR8jLBBzH3pw+/IUcRbAnLQP4zFpMwmGy9LCm/ mawC+WqDGSjbyVzgCUFlMd2c6I0MSJS3/iRINoE4KLOBA8rPIqLMOnPdsLdLYnx4w3w9 qug8HMbftQHHSEK4S/wJ6gPYajl4ceUfdnVK4B3TWjAvrLJw295IIlAA96uRHrziTzja uzFU2vSLPOyAIsphzPf2YFvpYilR6+eCdUCGUL884az+YaTM2266ujXOAQym3psMfaTd K/nw== X-Gm-Message-State: AG10YOQ4iFWQvFh3IoY7fyhfHLpyGJ072IwOhPDcMclo1XEQTBC/HXl7u3r4IdfMRoQgxeIV X-Received: by 10.194.157.3 with SMTP id wi3mr42254490wjb.30.1455147940976; Wed, 10 Feb 2016 15:45:40 -0800 (PST) Received: from saturne.dev.6wind.com.kubiwireless.com ([195.77.232.109]) by smtp.gmail.com with ESMTPSA id g126sm9142560wmf.16.2016.02.10.15.45.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Feb 2016 15:45:40 -0800 (PST) From: Vincent JARDIN To: dev@dpdk.org Date: Thu, 11 Feb 2016 00:45:34 +0100 Message-Id: <1455147934-15060-1-git-send-email-vincent.jardin@6wind.com> X-Mailer: git-send-email 2.1.0 Subject: [dpdk-dev] [PATCH] virtio: prettify log messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2016 23:45:41 -0000 PMD_TX_LOG() looks better with a \n Signed-off-by: Vincent JARDIN --- drivers/net/virtio/virtio_rxtx.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 41a1366..c03d36a 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -825,7 +825,7 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) if (unlikely(nb_pkts < 1)) return nb_pkts; - PMD_TX_LOG(DEBUG, "%d packets to xmit", nb_pkts); + PMD_TX_LOG(DEBUG, "%d packets to xmit\n", nb_pkts); nb_used = VIRTQUEUE_NUSED(txvq); virtio_rmb(); @@ -847,7 +847,7 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) need = txm->nb_segs - txvq->vq_free_cnt + 1; if (unlikely(need > 0)) { PMD_TX_LOG(ERR, - "No free tx descriptors to transmit"); + "No free tx descriptors to transmit\n"); break; } } @@ -865,11 +865,11 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) error = virtqueue_enqueue_xmit(txvq, txm); if (unlikely(error)) { if (error == ENOSPC) - PMD_TX_LOG(ERR, "virtqueue_enqueue Free count = 0"); + PMD_TX_LOG(ERR, "virtqueue_enqueue Free count = 0\n"); else if (error == EMSGSIZE) - PMD_TX_LOG(ERR, "virtqueue_enqueue Free count < 1"); + PMD_TX_LOG(ERR, "virtqueue_enqueue Free count < 1\n"); else - PMD_TX_LOG(ERR, "virtqueue_enqueue error: %d", error); + PMD_TX_LOG(ERR, "virtqueue_enqueue error: %d\n", error); break; } @@ -884,7 +884,7 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) if (unlikely(virtqueue_kick_prepare(txvq))) { virtqueue_notify(txvq); - PMD_TX_LOG(DEBUG, "Notified backend after xmit"); + PMD_TX_LOG(DEBUG, "Notified backend after xmit\n"); } } -- 2.1.0