From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 405ECC13E for ; Tue, 16 Feb 2016 15:48:50 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 16 Feb 2016 06:48:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,455,1449561600"; d="scan'208";a="886052399" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga001.jf.intel.com with ESMTP; 16 Feb 2016 06:48:47 -0800 Received: from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com [10.237.217.46]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id u1GEmlmk011226; Tue, 16 Feb 2016 14:48:47 GMT Received: from sivswdev02.ir.intel.com (localhost [127.0.0.1]) by sivswdev02.ir.intel.com with ESMTP id u1GEmlcJ004238; Tue, 16 Feb 2016 14:48:47 GMT Received: (from dhunt5@localhost) by sivswdev02.ir.intel.com with id u1GEmkis004234; Tue, 16 Feb 2016 14:48:46 GMT From: David Hunt To: dev@dpdk.org Date: Tue, 16 Feb 2016 14:48:09 +0000 Message-Id: <1455634095-4183-1-git-send-email-david.hunt@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1453829155-1366-1-git-send-email-david.hunt@intel.com> References: <1453829155-1366-1-git-send-email-david.hunt@intel.com> Subject: [dpdk-dev] [PATCH 0/6] external mempool manager X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2016 14:48:50 -0000 Hi list. Here's the v2 version of a proposed patch for an external mempool manager v2 changes: * There was a lot of duplicate code between rte_mempool_xmem_create and rte_mempool_create_ext. This has now been refactored and is now hopefully cleaner. * The RTE_NEXT_ABI define is now used to allow building of the library in a format that is compatible with binaries built against previous versions of DPDK. * Changes out of code reviews. Hopefully I've got most of them included. The External Mempool Manager is an extension to the mempool API that allows users to add and use an external mempool manager, which allows external memory subsystems such as external hardware memory management systems and software based memory allocators to be used with DPDK. The existing API to the internal DPDK mempool manager will remain unchanged and will be backward compatible. However, there will be an ABI breakage, as the mempool struct is changing. These changes are all contained withing RTE_NEXT_ABI defs, and the current or next code can be changed with the CONFIG_RTE_NEXT_ABI config setting There are two aspects to external mempool manager. 1. Adding the code for your new mempool handler. This is achieved by adding a new mempool handler source file into the librte_mempool library, and using the REGISTER_MEMPOOL_HANDLER macro. 2. Using the new API to call rte_mempool_create_ext to create a new mempool using the name parameter to identify which handler to use. New API calls added 1. A new mempool 'create' function which accepts mempool handler name. 2. A new mempool 'rte_get_mempool_handler' function which accepts mempool handler name, and returns the index to the relevant set of callbacks for that mempool handler Several external mempool managers may be used in the same application. A new mempool can then be created by using the new 'create' function, providing the mempool handler name to point the mempool to the relevant mempool manager callback structure. The old 'create' function can still be called by legacy programs, and will internally work out the mempool handle based on the flags provided (single producer, single consumer, etc). By default handles are created internally to implement the built-in DPDK mempool manager and mempool types. The external mempool manager needs to provide the following functions. 1. alloc - allocates the mempool memory, and adds each object onto a ring 2. put - puts an object back into the mempool once an application has finished with it 3. get - gets an object from the mempool for use by the application 4. get_count - gets the number of available objects in the mempool 5. free - frees the mempool memory Every time a get/put/get_count is called from the application/PMD, the callback for that mempool is called. These functions are in the fastpath, and any unoptimised handlers may limit performance. The new APIs are as follows: 1. rte_mempool_create_ext struct rte_mempool * rte_mempool_create_ext(const char * name, unsigned n, unsigned cache_size, unsigned private_data_size, int socket_id, unsigned flags, const char * handler_name); 2. rte_mempool_get_handler_name char * rte_mempool_get_handler_name(struct rte_mempool *mp); Please see rte_mempool.h for further information on the parameters. The important thing to note is that the mempool handler is passed by name to rte_mempool_create_ext, and that in turn calls rte_get_mempool_handler to get the handler index, which is stored in the rte_memool structure. This allow multiple processes to use the same mempool, as the function pointers are accessed via handler index. The mempool handler structure contains callbacks to the implementation of the handler, and is set up for registration as follows: static struct rte_mempool_handler handler_sp_mc = { .name = "ring_sp_mc", .alloc = rte_mempool_common_ring_alloc, .put = common_ring_sp_put, .get = common_ring_mc_get, .get_count = common_ring_get_count, .free = common_ring_free, }; And then the following macro will register the handler in the array of handlers REGISTER_MEMPOOL_HANDLER(handler_mp_mc); For and example of a simple malloc based mempool manager, see lib/librte_mempool/custom_mempool.c For an example of API usage, please see app/test/test_ext_mempool.c, which implements a rudimentary mempool manager using simple mallocs for each mempool object (custom_mempool.c). David Hunt (6): mempool: add external mempool manager support mempool: add stack (lifo) based external mempool handler mempool: adds a simple ring-based mempool handler using mallocs for objects mempool: add autotest for external mempool custom example mempool: allow rte_pktmbuf_pool_create switch between memool handlers mempool: add in the RTE_NEXT_ABI protection for ABI breakages app/test/Makefile | 3 + app/test/test_ext_mempool.c | 451 +++++++++++++++++++++++++++++ app/test/test_mempool_perf.c | 2 + config/common_bsdapp | 2 + config/common_linuxapp | 2 + lib/librte_mbuf/rte_mbuf.c | 15 + lib/librte_mempool/Makefile | 5 + lib/librte_mempool/custom_mempool.c | 146 ++++++++++ lib/librte_mempool/rte_mempool.c | 383 ++++++++++++++++++++++-- lib/librte_mempool/rte_mempool.h | 213 +++++++++++++- lib/librte_mempool/rte_mempool_default.c | 236 +++++++++++++++ lib/librte_mempool/rte_mempool_internal.h | 75 +++++ lib/librte_mempool/rte_mempool_stack.c | 164 +++++++++++ lib/librte_mempool/rte_mempool_version.map | 1 + 14 files changed, 1665 insertions(+), 33 deletions(-) create mode 100644 app/test/test_ext_mempool.c create mode 100644 lib/librte_mempool/custom_mempool.c create mode 100644 lib/librte_mempool/rte_mempool_default.c create mode 100644 lib/librte_mempool/rte_mempool_internal.h create mode 100644 lib/librte_mempool/rte_mempool_stack.c -- 2.5.0