* [dpdk-dev] [PATCH] enic: fix last packet being not sent bug
@ 2016-02-22 1:06 johndale
2016-02-22 1:28 ` [dpdk-dev] [PATCH v2] " johndale
2016-02-22 1:45 ` [dpdk-dev] [PATCH v3] " johndale
0 siblings, 2 replies; 5+ messages in thread
From: johndale @ 2016-02-22 1:06 UTC (permalink / raw)
To: dev; +Cc: johndale
The last packet of the tx burst function array was not being
emitted until the subsequent call. The nic descriptor index
was being set to the current tx descriptr instead of one past the
the descriptor as required by nic.
Signed-off-by: johndale <johndale@cisco.com>
---
drivers/net/enic/base/enic_vnic_wq.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/enic/base/enic_vnic_wq.h b/drivers/net/enic/base/enic_vnic_wq.h
index e3ea574..b019109 100644
--- a/drivers/net/enic/base/enic_vnic_wq.h
+++ b/drivers/net/enic/base/enic_vnic_wq.h
@@ -69,11 +69,11 @@ static inline void enic_vnic_post_wq(struct vnic_wq *wq,
buf->wr_id = wrid;
buf = buf->next;
- if (cq_entry)
- enic_vnic_post_wq_index(wq);
+ wq->ring.desc_avail -= desc_skip_cnt;
wq->to_use = buf;
- wq->ring.desc_avail -= desc_skip_cnt;
+ if (cq_entry)
+ enic_vnic_post_wq_index(wq);
}
#endif /* _ENIC_VNIC_WQ_H_ */
--
2.7.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] enic: fix last packet being not sent bug
2016-02-22 1:06 [dpdk-dev] [PATCH] enic: fix last packet being not sent bug johndale
@ 2016-02-22 1:28 ` johndale
2016-02-22 1:45 ` [dpdk-dev] [PATCH v3] " johndale
1 sibling, 0 replies; 5+ messages in thread
From: johndale @ 2016-02-22 1:28 UTC (permalink / raw)
To: dev; +Cc: johndale
Oops, forgot sign-off.
The last packet of the tx burst function array was not being
emitted until the subsequent call. The nic descriptor index
was being set to the current tx descriptr instead of one past the
the descriptor as required by nic.
Signed-off-by: johndale <johndale@cisco.com>
---
drivers/net/enic/base/enic_vnic_wq.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/enic/base/enic_vnic_wq.h b/drivers/net/enic/base/enic_vnic_wq.h
index e3ea574..b019109 100644
--- a/drivers/net/enic/base/enic_vnic_wq.h
+++ b/drivers/net/enic/base/enic_vnic_wq.h
@@ -69,11 +69,11 @@ static inline void enic_vnic_post_wq(struct vnic_wq *wq,
buf->wr_id = wrid;
buf = buf->next;
- if (cq_entry)
- enic_vnic_post_wq_index(wq);
+ wq->ring.desc_avail -= desc_skip_cnt;
wq->to_use = buf;
- wq->ring.desc_avail -= desc_skip_cnt;
+ if (cq_entry)
+ enic_vnic_post_wq_index(wq);
}
#endif /* _ENIC_VNIC_WQ_H_ */
--
2.7.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v3] enic: fix last packet being not sent bug
2016-02-22 1:06 [dpdk-dev] [PATCH] enic: fix last packet being not sent bug johndale
2016-02-22 1:28 ` [dpdk-dev] [PATCH v2] " johndale
@ 2016-02-22 1:45 ` johndale
2016-03-08 18:49 ` [dpdk-dev] [PATCH v4] " John Daley
1 sibling, 1 reply; 5+ messages in thread
From: johndale @ 2016-02-22 1:45 UTC (permalink / raw)
To: dev; +Cc: johndale
The last packet of the tx burst function array was not being
emitted until the subsequent call. The nic descriptor index
was being set to the current tx descriptr instead of one past the
the descriptor as required by nic.
Signed-off-by: johndale <johndale@cisco.com>
---
Forgot sign-off, annotated message in wrong spot.
drivers/net/enic/base/enic_vnic_wq.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/enic/base/enic_vnic_wq.h b/drivers/net/enic/base/enic_vnic_wq.h
index e3ea574..b019109 100644
--- a/drivers/net/enic/base/enic_vnic_wq.h
+++ b/drivers/net/enic/base/enic_vnic_wq.h
@@ -69,11 +69,11 @@ static inline void enic_vnic_post_wq(struct vnic_wq *wq,
buf->wr_id = wrid;
buf = buf->next;
- if (cq_entry)
- enic_vnic_post_wq_index(wq);
+ wq->ring.desc_avail -= desc_skip_cnt;
wq->to_use = buf;
- wq->ring.desc_avail -= desc_skip_cnt;
+ if (cq_entry)
+ enic_vnic_post_wq_index(wq);
}
#endif /* _ENIC_VNIC_WQ_H_ */
--
2.7.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v4] enic: fix last packet being not sent bug
2016-02-22 1:45 ` [dpdk-dev] [PATCH v3] " johndale
@ 2016-03-08 18:49 ` John Daley
2016-03-11 17:23 ` Bruce Richardson
0 siblings, 1 reply; 5+ messages in thread
From: John Daley @ 2016-03-08 18:49 UTC (permalink / raw)
To: dev; +Cc: johndale
From: johndale <johndale@cisco.com>
The last packet of the tx burst function array was not being
emitted until the subsequent call. The nic descriptor index
was being set to the current tx descriptr instead of one past the
the descriptor as required by nic.
Fixes: d739ba4c6abf ("enic: improve Tx packet rate")
Signed-off-by: John Daley <johndale@cisco.com>
---
Use full nime in 'Signed-off-by', add 'Fixes:'.
drivers/net/enic/base/enic_vnic_wq.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/enic/base/enic_vnic_wq.h b/drivers/net/enic/base/enic_vnic_wq.h
index e3ea574..b019109 100644
--- a/drivers/net/enic/base/enic_vnic_wq.h
+++ b/drivers/net/enic/base/enic_vnic_wq.h
@@ -69,11 +69,11 @@ static inline void enic_vnic_post_wq(struct vnic_wq *wq,
buf->wr_id = wrid;
buf = buf->next;
- if (cq_entry)
- enic_vnic_post_wq_index(wq);
+ wq->ring.desc_avail -= desc_skip_cnt;
wq->to_use = buf;
- wq->ring.desc_avail -= desc_skip_cnt;
+ if (cq_entry)
+ enic_vnic_post_wq_index(wq);
}
#endif /* _ENIC_VNIC_WQ_H_ */
--
2.7.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v4] enic: fix last packet being not sent bug
2016-03-08 18:49 ` [dpdk-dev] [PATCH v4] " John Daley
@ 2016-03-11 17:23 ` Bruce Richardson
0 siblings, 0 replies; 5+ messages in thread
From: Bruce Richardson @ 2016-03-11 17:23 UTC (permalink / raw)
To: John Daley; +Cc: dev
On Tue, Mar 08, 2016 at 10:49:07AM -0800, John Daley wrote:
> From: johndale <johndale@cisco.com>
>
> The last packet of the tx burst function array was not being
> emitted until the subsequent call. The nic descriptor index
> was being set to the current tx descriptr instead of one past the
> the descriptor as required by nic.
>
> Fixes: d739ba4c6abf ("enic: improve Tx packet rate")
> Signed-off-by: John Daley <johndale@cisco.com>
Applied to dpdk-next-net/rel_16_04
/Bruce
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-11 17:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-22 1:06 [dpdk-dev] [PATCH] enic: fix last packet being not sent bug johndale
2016-02-22 1:28 ` [dpdk-dev] [PATCH v2] " johndale
2016-02-22 1:45 ` [dpdk-dev] [PATCH v3] " johndale
2016-03-08 18:49 ` [dpdk-dev] [PATCH v4] " John Daley
2016-03-11 17:23 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).