From: Thomas Monjalon <thomas@monjalon.net>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com,
navasile@linux.microsoft.com, dmitrym@microsoft.com,
ophirmu@nvidia.com, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/windows: fix missing header inclusion
Date: Tue, 20 Oct 2020 13:47:21 +0200 [thread overview]
Message-ID: <145746135.qdezSroZQ7@thomas> (raw)
In-Reply-To: <20201020123752.6e266990@sovereign>
20/10/2020 11:37, Dmitry Kozlyuk:
> On Tue, 20 Oct 2020 11:48:15 +0300, Tal Shnaiderman wrote:
> > Following the addition of the in_addr/in6_addr structs
> > to in.h the header file must have stdint.h included
> > for the definitions of the uint8_t/uint32_t types used
> > within the new structs.
> >
> > Not having it could results in the following errors
> > in places where in.h is included:
> >
> > in.h:30:2: error: unknown type name 'uint32_t'
> > uint32_t s_addr;
> >
> > in.h:34:2: error: unknown type name 'uint8_t'
> > uint8_t s6_addr[16];
> >
> > Fixes: f40a74cfcf0 ("eal/windows: improve compatibility networking headers")
> > Cc: stable@dpdk.org
Removing stable@dpdk.org as the bug is only in current release.
> >
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
>
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Applied, thanks
prev parent reply other threads:[~2020-10-20 11:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 8:48 [dpdk-dev] " Tal Shnaiderman
2020-10-20 9:37 ` Dmitry Kozlyuk
2020-10-20 11:47 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=145746135.qdezSroZQ7@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=ophirmu@nvidia.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).