* [dpdk-dev] [PATCH] eal/windows: fix missing header inclusion
@ 2020-10-20 8:48 Tal Shnaiderman
2020-10-20 9:37 ` Dmitry Kozlyuk
0 siblings, 1 reply; 3+ messages in thread
From: Tal Shnaiderman @ 2020-10-20 8:48 UTC (permalink / raw)
To: dev
Cc: thomas, pallavi.kadam, dmitry.kozliuk, ranjit.menon, navasile,
dmitrym, ophirmu, stable
Following the addition of the in_addr/in6_addr structs
to in.h the header file must have stdint.h included
for the definitions of the uint8_t/uint32_t types used
within the new structs.
Not having it could results in the following errors
in places where in.h is included:
in.h:30:2: error: unknown type name 'uint32_t'
uint32_t s_addr;
in.h:34:2: error: unknown type name 'uint8_t'
uint8_t s6_addr[16];
Fixes: f40a74cfcf0 ("eal/windows: improve compatibility networking headers")
Cc: stable@dpdk.org
Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
lib/librte_eal/windows/include/netinet/in.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/windows/include/netinet/in.h b/lib/librte_eal/windows/include/netinet/in.h
index be1469ec11..6455b9ba51 100644
--- a/lib/librte_eal/windows/include/netinet/in.h
+++ b/lib/librte_eal/windows/include/netinet/in.h
@@ -5,6 +5,7 @@
#ifndef _IN_H_
#define _IN_H_
+#include <stdint.h>
#include <sys/socket.h>
#define IPPROTO_IP 0
--
2.16.1.windows.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/windows: fix missing header inclusion
2020-10-20 8:48 [dpdk-dev] [PATCH] eal/windows: fix missing header inclusion Tal Shnaiderman
@ 2020-10-20 9:37 ` Dmitry Kozlyuk
2020-10-20 11:47 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Kozlyuk @ 2020-10-20 9:37 UTC (permalink / raw)
To: Tal Shnaiderman
Cc: dev, thomas, pallavi.kadam, ranjit.menon, navasile, dmitrym,
ophirmu, stable
On Tue, 20 Oct 2020 11:48:15 +0300, Tal Shnaiderman wrote:
> Following the addition of the in_addr/in6_addr structs
> to in.h the header file must have stdint.h included
> for the definitions of the uint8_t/uint32_t types used
> within the new structs.
>
> Not having it could results in the following errors
> in places where in.h is included:
>
> in.h:30:2: error: unknown type name 'uint32_t'
> uint32_t s_addr;
>
> in.h:34:2: error: unknown type name 'uint8_t'
> uint8_t s6_addr[16];
>
> Fixes: f40a74cfcf0 ("eal/windows: improve compatibility networking headers")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
> lib/librte_eal/windows/include/netinet/in.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_eal/windows/include/netinet/in.h b/lib/librte_eal/windows/include/netinet/in.h
> index be1469ec11..6455b9ba51 100644
> --- a/lib/librte_eal/windows/include/netinet/in.h
> +++ b/lib/librte_eal/windows/include/netinet/in.h
> @@ -5,6 +5,7 @@
> #ifndef _IN_H_
> #define _IN_H_
>
> +#include <stdint.h>
> #include <sys/socket.h>
>
> #define IPPROTO_IP 0
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/windows: fix missing header inclusion
2020-10-20 9:37 ` Dmitry Kozlyuk
@ 2020-10-20 11:47 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-10-20 11:47 UTC (permalink / raw)
To: Tal Shnaiderman
Cc: dev, pallavi.kadam, ranjit.menon, navasile, dmitrym, ophirmu,
Dmitry Kozlyuk
20/10/2020 11:37, Dmitry Kozlyuk:
> On Tue, 20 Oct 2020 11:48:15 +0300, Tal Shnaiderman wrote:
> > Following the addition of the in_addr/in6_addr structs
> > to in.h the header file must have stdint.h included
> > for the definitions of the uint8_t/uint32_t types used
> > within the new structs.
> >
> > Not having it could results in the following errors
> > in places where in.h is included:
> >
> > in.h:30:2: error: unknown type name 'uint32_t'
> > uint32_t s_addr;
> >
> > in.h:34:2: error: unknown type name 'uint8_t'
> > uint8_t s6_addr[16];
> >
> > Fixes: f40a74cfcf0 ("eal/windows: improve compatibility networking headers")
> > Cc: stable@dpdk.org
Removing stable@dpdk.org as the bug is only in current release.
> >
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
>
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-20 11:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20 8:48 [dpdk-dev] [PATCH] eal/windows: fix missing header inclusion Tal Shnaiderman
2020-10-20 9:37 ` Dmitry Kozlyuk
2020-10-20 11:47 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).