From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id EA4CB275D for ; Fri, 11 Mar 2016 14:30:03 +0100 (CET) Received: from glumotte.dev.6wind.com (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id D009B24AE1; Fri, 11 Mar 2016 14:29:20 +0100 (CET) From: Olivier Matz To: dev@dpdk.org Date: Fri, 11 Mar 2016 14:29:40 +0100 Message-Id: <1457702980-26816-1-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.1.4 Subject: [dpdk-dev] [PATCH] mk: fix static build without crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2016 13:30:04 -0000 If the experimental CONFIG_RTE_LIBRTE_CRYPTODEV is disabled, build of any crypto pmds will fail because of the missing dependency. The commit 94288d645 fixes the issue when compiled with shared libraries but there is still an issue at link time with static libs: LD test /usr/bin/ld: cannot find -lrte_pmd_null_crypto collect2: error: ld returned 1 exit status Only add the -l linker flags related to crypto PMDs if CRYPTODEV is enabled. Fixes: 94288d645 ("mk: fix build without crypto") Signed-off-by: Olivier Matz --- mk/rte.app.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 165caa6..30a91ad 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -148,8 +148,9 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_RING) += -lrte_pmd_ring _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += -lrte_pmd_pcap _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += -lrte_pmd_af_packet _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += -lrte_pmd_null -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += -lrte_pmd_qat +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += -lrte_pmd_qat _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += -lrte_pmd_aesni_mb _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_GCM) += -lrte_pmd_aesni_gcm _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) += -lrte_pmd_null_crypto @@ -164,6 +165,7 @@ endif # SNOW3G PMD is dependent on the LIBSSO library _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SNOW3G) += -lrte_pmd_snow3g _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SNOW3G) += -L$(LIBSSO_PATH)/build -lsso +endif # CONFIG_RTE_LIBRTE_CRYPTODEV endif # ! $(CONFIG_RTE_BUILD_SHARED_LIB) -- 2.1.4