From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 859E02BD7 for ; Tue, 22 Mar 2016 14:13:53 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 22 Mar 2016 06:13:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,377,1455004800"; d="scan'208";a="929375449" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by fmsmga001.fm.intel.com with ESMTP; 22 Mar 2016 06:13:51 -0700 Received: from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com [10.239.29.89]) by shvmail01.sh.intel.com with ESMTP id u2MDDo2a012414; Tue, 22 Mar 2016 21:13:50 +0800 Received: from shecgisg004.sh.intel.com (localhost [127.0.0.1]) by shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id u2MDDlAH006202; Tue, 22 Mar 2016 21:13:49 +0800 Received: (from zhetao@localhost) by shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id u2MDDlT7006198; Tue, 22 Mar 2016 21:13:47 +0800 From: Zhe Tao To: dev@dpdk.org Cc: zhe.tao@intel.com Date: Tue, 22 Mar 2016 21:13:45 +0800 Message-Id: <1458652425-6167-1-git-send-email-zhe.tao@intel.com> X-Mailer: git-send-email 1.7.4.1 Subject: [dpdk-dev] [PATCH] i40e: fix ipv6 TSO issue for tx function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2016 13:13:53 -0000 Issue: when using the following CLI in testpmd to enable ipv6 TSO feature ============= set verbose 1 csum set ip hw 0 csum set udp hw 0 csum set tcp hw 0 csum set sctp hw 0 csum set outer-ip hw 0 csum parse_tunnel on 0 tso set 800 0 set fwd csum start ============= We will not get we want, the ipv6 packets sent out from IXIA can be received by i40e, but cannot forward to another port. The root cause is when HW doing the TSO offload for packets, it not only depends on the context descriptor to define the MSS and TSO payload size, it also need to know whether this packets is ipv4 or ipv6, ipv4 need the header csum, but ipv6 doesn't need the csum. We need to use the i40e_txd_enable_checksum to set the ipv6 type flag into the data descriptor when the packets are for ipv6 TSO. Fixes: e3f0151f (i40e: enable Tx checksum only for offloaded packets) Signed-off-by: Zhe Tao --- drivers/net/i40e/i40e_rxtx.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 1488f2f..ffd6dba 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -1545,6 +1545,7 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) uint16_t slen; uint64_t buf_dma_addr; union i40e_tx_offload tx_offload = {0}; + bool enable_checksum = 0; txq = tx_queue; sw_ring = txq->sw_ring; @@ -1620,7 +1621,13 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) /* Enable checksum offloading */ cd_tunneling_params = 0; - if (ol_flags & I40E_TX_CKSUM_OFFLOAD_MASK) { + /* Check whether need to do checksum or not */ + if ((ol_flags & I40E_TX_CKSUM_OFFLOAD_MASK) || + ((ol_flags & PKT_TX_IPV6) && (ol_flags & PKT_TX_TCP_SEG))) { + enable_checksum = 1; + } + + if (enable_checksum) { i40e_txd_enable_checksum(ol_flags, &td_cmd, &td_offset, tx_offload, &cd_tunneling_params); } -- 2.1.4