* [dpdk-dev] [PATCH] l2fwd-crypto: fix incorrect parameter in help
@ 2016-03-22 13:21 Pablo de Lara
2016-03-22 15:07 ` Trahe, Fiona
2016-03-24 13:39 ` [dpdk-dev] [PATCH v2] l2fwd-crypto: fix incorrect command line help Pablo de Lara
0 siblings, 2 replies; 6+ messages in thread
From: Pablo de Lara @ 2016-03-22 13:21 UTC (permalink / raw)
To: dev; +Cc: declan.doherty, Pablo de Lara
Previous cdev parameter was changed to cdev_type,
to select a crypto device type preference (HW/SW/ANY),
instead of the device itself (QAT/AESNI...).
Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
examples/l2fwd-crypto/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index 762d22a..59f8c92 100644
--- a/examples/l2fwd-crypto/main.c
+++ b/examples/l2fwd-crypto/main.c
@@ -769,7 +769,7 @@ l2fwd_crypto_usage(const char *prgname)
" -t PERIOD: statistics will be refreshed each PERIOD seconds"
" (0 to disable, 10 default, 86400 maximum)\n"
- " --cdev AESNI_MB / QAT\n"
+ " --cdev_type HW / SW / ANY\n"
" --chain HASH_CIPHER / CIPHER_HASH\n"
" --cipher_algo ALGO\n"
--
2.5.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] l2fwd-crypto: fix incorrect parameter in help
2016-03-22 13:21 [dpdk-dev] [PATCH] l2fwd-crypto: fix incorrect parameter in help Pablo de Lara
@ 2016-03-22 15:07 ` Trahe, Fiona
2016-03-24 13:37 ` De Lara Guarch, Pablo
2016-03-24 13:39 ` [dpdk-dev] [PATCH v2] l2fwd-crypto: fix incorrect command line help Pablo de Lara
1 sibling, 1 reply; 6+ messages in thread
From: Trahe, Fiona @ 2016-03-22 15:07 UTC (permalink / raw)
To: De Lara Guarch, Pablo, dev; +Cc: Doherty, Declan, De Lara Guarch, Pablo
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Tuesday, March 22, 2016 1:21 PM
> To: dev@dpdk.org
> Cc: Doherty, Declan; De Lara Guarch, Pablo
> Subject: [dpdk-dev] [PATCH] l2fwd-crypto: fix incorrect parameter in help
>
> Previous cdev parameter was changed to cdev_type, to select a crypto device
> type preference (HW/SW/ANY), instead of the device itself (QAT/AESNI...).
>
> Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] l2fwd-crypto: fix incorrect parameter in help
2016-03-22 15:07 ` Trahe, Fiona
@ 2016-03-24 13:37 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 6+ messages in thread
From: De Lara Guarch, Pablo @ 2016-03-24 13:37 UTC (permalink / raw)
To: Trahe, Fiona, dev; +Cc: Doherty, Declan
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Tuesday, March 22, 2016 3:08 PM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Cc: Doherty, Declan; De Lara Guarch, Pablo
> Subject: RE: [dpdk-dev] [PATCH] l2fwd-crypto: fix incorrect parameter in help
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> > Sent: Tuesday, March 22, 2016 1:21 PM
> > To: dev@dpdk.org
> > Cc: Doherty, Declan; De Lara Guarch, Pablo
> > Subject: [dpdk-dev] [PATCH] l2fwd-crypto: fix incorrect parameter in help
> >
> > Previous cdev parameter was changed to cdev_type, to select a crypto
> device
> > type preference (HW/SW/ANY), instead of the device itself (QAT/AESNI...).
> >
> > Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Self-NACK. The cdev parameter in the command line help is duplicated,
so I will use this patch to fix it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] l2fwd-crypto: fix incorrect command line help
2016-03-22 13:21 [dpdk-dev] [PATCH] l2fwd-crypto: fix incorrect parameter in help Pablo de Lara
2016-03-22 15:07 ` Trahe, Fiona
@ 2016-03-24 13:39 ` Pablo de Lara
2016-03-24 17:00 ` Trahe, Fiona
1 sibling, 1 reply; 6+ messages in thread
From: Pablo de Lara @ 2016-03-24 13:39 UTC (permalink / raw)
To: dev; +Cc: declan.doherty, Pablo de Lara
Previous cdev parameter was changed to cdev_type,
to select a crypto device type preference (HW/SW/ANY),
instead of the device itself (QAT/AESNI...).
Also deleted cdev duplicated parameter from the help.
Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
---
Changes in v2:
- Removed duplicated parameter in command line help
examples/l2fwd-crypto/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index 762d22a..ba0dcba 100644
--- a/examples/l2fwd-crypto/main.c
+++ b/examples/l2fwd-crypto/main.c
@@ -762,14 +762,14 @@ l2fwd_launch_one_lcore(void *arg)
static void
l2fwd_crypto_usage(const char *prgname)
{
- printf("%s [EAL options] -- --cdev TYPE [optional parameters]\n"
+ printf("%s [EAL options] --\n"
" -p PORTMASK: hexadecimal bitmask of ports to configure\n"
" -q NQ: number of queue (=ports) per lcore (default is 1)\n"
" -s manage all ports from single lcore"
" -t PERIOD: statistics will be refreshed each PERIOD seconds"
" (0 to disable, 10 default, 86400 maximum)\n"
- " --cdev AESNI_MB / QAT\n"
+ " --cdev_type HW / SW / ANY\n"
" --chain HASH_CIPHER / CIPHER_HASH\n"
" --cipher_algo ALGO\n"
--
2.5.5
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2] l2fwd-crypto: fix incorrect command line help
2016-03-24 13:39 ` [dpdk-dev] [PATCH v2] l2fwd-crypto: fix incorrect command line help Pablo de Lara
@ 2016-03-24 17:00 ` Trahe, Fiona
2016-03-24 19:48 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Trahe, Fiona @ 2016-03-24 17:00 UTC (permalink / raw)
To: dev; +Cc: Doherty, Declan, De Lara Guarch, Pablo
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, March 24, 2016 1:40 PM
> To: dev@dpdk.org
> Cc: Doherty, Declan; De Lara Guarch, Pablo
> Subject: [dpdk-dev] [PATCH v2] l2fwd-crypto: fix incorrect command line help
>
> Previous cdev parameter was changed to cdev_type, to select a crypto device
> type preference (HW/SW/ANY), instead of the device itself (QAT/AESNI...).
> Also deleted cdev duplicated parameter from the help.
>
> Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
>
> Changes in v2:
> - Removed duplicated parameter in command line help
>
> examples/l2fwd-crypto/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2] l2fwd-crypto: fix incorrect command line help
2016-03-24 17:00 ` Trahe, Fiona
@ 2016-03-24 19:48 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2016-03-24 19:48 UTC (permalink / raw)
To: De Lara Guarch, Pablo; +Cc: dev, Trahe, Fiona, Doherty, Declan
> > Previous cdev parameter was changed to cdev_type, to select a crypto device
> > type preference (HW/SW/ANY), instead of the device itself (QAT/AESNI...).
> > Also deleted cdev duplicated parameter from the help.
> >
> > Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> > ---
> >
> > Changes in v2:
> > - Removed duplicated parameter in command line help
> >
> > examples/l2fwd-crypto/main.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-24 19:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-22 13:21 [dpdk-dev] [PATCH] l2fwd-crypto: fix incorrect parameter in help Pablo de Lara
2016-03-22 15:07 ` Trahe, Fiona
2016-03-24 13:37 ` De Lara Guarch, Pablo
2016-03-24 13:39 ` [dpdk-dev] [PATCH v2] l2fwd-crypto: fix incorrect command line help Pablo de Lara
2016-03-24 17:00 ` Trahe, Fiona
2016-03-24 19:48 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).