From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7BC531B3DE for <dev@dpdk.org>; Fri, 26 Jan 2018 11:07:28 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DF43120F7C; Fri, 26 Jan 2018 05:07:27 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 26 Jan 2018 05:07:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=sM04iaJFctOdDVxeaw4VwfouNX b6TJXeuiNaYfU2mo4=; b=PWAwA3ehfFuUfWyoq+BENSbdjkOLq1xQivNoPqAowf H1ZCdLq4b41E8GigwuwQnQAkvoFTqvBw03/RBdZ8oOyTN+yZLLCNzyPTFP+yjg9k fo70R9ANQGT6kEPRMnchGqZuQ3qIUUixeJu2JXkNGOIp/lKoq65zE6jSIqg5oKU4 c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=sM04ia JFctOdDVxeaw4VwfouNXb6TJXeuiNaYfU2mo4=; b=MByXy8X6zgxSmTxzCwFHaU qU15gs199VEH3bRj0fAofo1rUxtPi1WLjUNLFBHRkC6jZf7LbzydVyvgd9MRrfBE zXqOfmvJfBmQ922umNl65cN0LKgHjMZL50U7u28UXgOhAFtnocAg8NUss270uXdi y5LIxxVqVjsKjuoRs5b5BpHtFE2rEGg/S6DHgCibHdjP+1uRBfMb4yyhn/Ujf8nR tOugEARyNOsilVpcwODBJ2bZHqrlOQ7hOvJYeaSNJIhlybR4lUMp1T9OqEgpHv1O xuNFp/lmMq6sFLgqng3DFWEH9N4Ha1HWO5DGRDy5jsGjv3JYS0DDNIm6LkgXgI7g == X-ME-Sender: <xms:3_1qWoSmsp1VoxYyEsV-8njIgSLaaT3Jmrf9PBiBsu-Krd0zdluzdA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 90DE97E12E; Fri, 26 Jan 2018 05:07:27 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Adrien Mazarguil <adrien.mazarguil@6wind.com> Cc: dev@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>, Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, Marcelo Ricardo Leitner <mleitner@redhat.com> Date: Fri, 26 Jan 2018 11:06:45 +0100 Message-ID: <14603063.HrPEEHIHji@xps> In-Reply-To: <20180124223625.1928-3-adrien.mazarguil@6wind.com> References: <20180124223625.1928-1-adrien.mazarguil@6wind.com> <20180124223625.1928-3-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 2/4] net/mlx4: spawn rdma-core dependency plug-in X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 26 Jan 2018 10:07:28 -0000 25/01/2018 00:25, Adrien Mazarguil: > --- a/drivers/net/mlx4/Makefile > +++ b/drivers/net/mlx4/Makefile > @@ -38,7 +38,11 @@ LIB = librte_pmd_mlx4.a > SRCS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += mlx4.c > SRCS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += mlx4_ethdev.c > SRCS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += mlx4_flow.c > +ifneq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > +SRCS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += mlx4_glue_lib.c > +else Using this dlopen mode to manage the dependency requirement should be a decision of the user/packager. Please introduce a new option which allows to enable/disable this mode, unrelated to the DPDK compilation mode being shared or static.