From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 29BE32E83 for ; Fri, 22 Apr 2016 13:15:06 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 22 Apr 2016 04:15:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,516,1455004800"; d="scan'208";a="964221379" Received: from gklab-246-020.igk.intel.com (HELO Sent) ([10.217.246.20]) by fmsmga002.fm.intel.com with SMTP; 22 Apr 2016 04:15:03 -0700 Received: by Sent (sSMTP sendmail emulation); Fri, 22 Apr 2016 12:44:22 +0200 From: Michal Kobylinski To: thomas.monjalon@6wind.com, dev@dpdk.org Cc: Michal Kobylinski Date: Fri, 22 Apr 2016 12:44:18 +0200 Message-Id: <1461321858-30339-1-git-send-email-michalx.kobylinski@intel.com> X-Mailer: git-send-email 1.9.1 Subject: [dpdk-dev] [PATCH] mem: fix overflowed return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2016 11:15:06 -0000 Fix issue reported by Coverity. Coverity ID 13255: Overflowed return value: The return value will be too small or even negative, likely resulting in unexpected behavior in a caller that uses the return value. In rte_mem_virt2phy: An integer overflow occurs, with the overflowed value used as the return value of the function Fixes: 3097de6e6bfb ("mem: get physical address of any pointer") Signed-off-by: Michal Kobylinski --- lib/librte_eal/linuxapp/eal/eal_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c index 5b9132c..6ceca5b 100644 --- a/lib/librte_eal/linuxapp/eal/eal_memory.c +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c @@ -195,7 +195,7 @@ rte_mem_virt2phy(const void *virtaddr) * the pfn (page frame number) are bits 0-54 (see * pagemap.txt in linux Documentation) */ - physaddr = ((page & 0x7fffffffffffffULL) * page_size) + physaddr = (uint64_t)((page & 0x7fffffffffffffULL) * page_size) + ((unsigned long)virtaddr % page_size); close(fd); return physaddr; -- 1.9.1