From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 822045477 for ; Thu, 28 Apr 2016 05:17:23 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 27 Apr 2016 20:17:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,545,1455004800"; d="scan'208";a="954488350" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by fmsmga001.fm.intel.com with ESMTP; 27 Apr 2016 20:17:18 -0700 Received: from shecgisg005.sh.intel.com (shecgisg005.sh.intel.com [10.239.39.67]) by shvmail01.sh.intel.com with ESMTP id u3S3HG5s022713; Thu, 28 Apr 2016 11:17:16 +0800 Received: from shecgisg005.sh.intel.com (localhost [127.0.0.1]) by shecgisg005.sh.intel.com with ESMTP id u3S3HG9e019449; Thu, 28 Apr 2016 11:17:16 +0800 Received: (from hzhan75@localhost) by shecgisg005.sh.intel.com with œ id u3S3HFlM019445; Thu, 28 Apr 2016 11:17:15 +0800 From: Helin Zhang To: dev@dpdk.org Cc: Helin Zhang Date: Thu, 28 Apr 2016 11:17:13 +0800 Message-Id: <1461813435-19251-1-git-send-email-helin.zhang@intel.com> X-Mailer: git-send-email 1.7.0.7 In-Reply-To: <1461563042-886-1-git-send-email-helin.zhang@intel.com> References: <1461563042-886-1-git-send-email-helin.zhang@intel.com> Subject: [dpdk-dev] [PATCH v3 0/2] fix Coverity reported issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2016 03:17:23 -0000 It fixes the issue reported by Coverity of 'Missing break in switch', by deleting 'case I40E_VIRTCHNL_OP_FCOE', as it is not necessary at all. It also fixes the issue reported by Coverity of 'Dereference before null check', by deleting null checks as they are not necessary at all, or move null checks before where uses it. v3: - Split the code changes into different patches, according to the issue type. - Reworded the commit logs. v2: - Combined all the patches into a single one, as suggested. - Remove checking rxq, as it shouldn't be NULL at any time. Helin Zhang (2): i40e: fix problematic dereference i40e: fix missing break in switch drivers/net/i40e/i40e_pf.c | 11 +++++------ drivers/net/i40e/i40e_rxtx.c | 10 +++++++--- 2 files changed, 12 insertions(+), 9 deletions(-) -- 2.5.0