From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id CC2B25477 for ; Thu, 28 Apr 2016 05:17:22 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 27 Apr 2016 20:17:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,545,1455004800"; d="scan'208";a="964325317" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by orsmga002.jf.intel.com with ESMTP; 27 Apr 2016 20:17:17 -0700 Received: from shecgisg005.sh.intel.com (shecgisg005.sh.intel.com [10.239.39.67]) by shvmail01.sh.intel.com with ESMTP id u3S3HGqo022719; Thu, 28 Apr 2016 11:17:16 +0800 Received: from shecgisg005.sh.intel.com (localhost [127.0.0.1]) by shecgisg005.sh.intel.com with ESMTP id u3S3HGJg019463; Thu, 28 Apr 2016 11:17:16 +0800 Received: (from hzhan75@localhost) by shecgisg005.sh.intel.com with œ id u3S3HGBM019459; Thu, 28 Apr 2016 11:17:16 +0800 From: Helin Zhang To: dev@dpdk.org Cc: Helin Zhang Date: Thu, 28 Apr 2016 11:17:15 +0800 Message-Id: <1461813435-19251-3-git-send-email-helin.zhang@intel.com> X-Mailer: git-send-email 1.7.0.7 In-Reply-To: <1461563042-886-1-git-send-email-helin.zhang@intel.com> References: <1461563042-886-1-git-send-email-helin.zhang@intel.com> Subject: [dpdk-dev] [PATCH v3 2/2] i40e: fix missing break in switch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2016 03:17:23 -0000 It fixes the issue reported by Coverity of 'Missing break in switch', by deleting 'case I40E_VIRTCHNL_OP_FCOE', as it is not necessary at all. Coverity ID 13265: Missing break in switch. Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_pf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 1bd599b..b47a374 100644 --- a/drivers/net/i40e/i40e_pf.c +++ b/drivers/net/i40e/i40e_pf.c @@ -997,11 +997,9 @@ i40e_pf_host_handle_vf_msg(struct rte_eth_dev *dev, PMD_DRV_LOG(INFO, "OP_CFG_VLAN_PVID received"); i40e_pf_host_process_cmd_cfg_pvid(vf, msg, msglen); break; - /* Don't add command supported below, which will - * return an error code. + /* Don't add command supported below, which will + * return an error code. */ - case I40E_VIRTCHNL_OP_FCOE: - PMD_DRV_LOG(ERR, "OP_FCOE received, not supported"); default: PMD_DRV_LOG(ERR, "%u received, not supported", opcode); i40e_pf_host_send_msg_to_vf(vf, opcode, I40E_ERR_PARAM, -- 2.5.0