From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <viktorin@rehivetech.com> Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16]) by dpdk.org (Postfix) with ESMTP id 97E01B3D4 for <dev@dpdk.org>; Tue, 10 May 2016 20:15:56 +0200 (CEST) Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz [147.229.13.147]) by wes1-so2.wedos.net (Postfix) with ESMTPSA id 3r46rD2smkz3rZ; Tue, 10 May 2016 20:15:56 +0200 (CEST) From: Jan Viktorin <viktorin@rehivetech.com> To: dev@dpdk.org Cc: Jan Viktorin <viktorin@rehivetech.com>, Thomas Monjalon <thomas.monjalon@6wind.com>, David Marchand <david.marchand@6wind.com>, Bruce Richardson <bruce.richardson@intel.com> Date: Tue, 10 May 2016 20:13:31 +0200 Message-Id: <1462904011-29838-12-git-send-email-viktorin@rehivetech.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1462904011-29838-1-git-send-email-viktorin@rehivetech.com> References: <1462904011-29838-1-git-send-email-viktorin@rehivetech.com> In-Reply-To: <1461935496-20367-1-git-send-email-viktorin@rehivetech.com> References: <1461935496-20367-1-git-send-email-viktorin@rehivetech.com> Subject: [dpdk-dev] [PATCH v2 11/11] app/test: do not dump PCI devices in blacklist test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 10 May 2016 18:15:56 -0000 Dumping of devices in a unittest is useless. Instead, test whether the test has been set up well - i.e. there are no devices. Signed-off-by: Jan Viktorin <viktorin@rehivetech.com> --- app/test/test_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_pci.c b/app/test/test_pci.c index 3c6c955..942fa09 100644 --- a/app/test/test_pci.c +++ b/app/test/test_pci.c @@ -150,8 +150,8 @@ test_pci_blacklist(void) { struct rte_devargs_list save_devargs_list; - printf("Dump all devices\n"); - rte_eal_pci_dump(stdout); + TEST_ASSERT(TAILQ_EMPTY(&pci_driver_list), + "pci_driver_list not empty"); rte_eal_pci_register(&my_driver); rte_eal_pci_register(&my_driver2); -- 2.8.0