From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E5C85B44F for ; Wed, 11 May 2016 06:04:15 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 10 May 2016 21:04:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,607,1455004800"; d="scan'208";a="803593834" Received: from yliu-dev.sh.intel.com ([10.239.67.162]) by orsmga003.jf.intel.com with ESMTP; 10 May 2016 21:04:14 -0700 From: Yuanhan Liu To: dev@dpdk.org Cc: Thomas Monjalon , Yuanhan Liu Date: Tue, 10 May 2016 21:09:01 -0700 Message-Id: <1462939741-12357-3-git-send-email-yuanhan.liu@linux.intel.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1462939741-12357-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1462939741-12357-1-git-send-email-yuanhan.liu@linux.intel.com> Subject: [dpdk-dev] [PATCH 2/2 RFC] scripts: high light bad patterns X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2016 04:04:16 -0000 I got a report like following: Wrong headline lowercase: xxx: move vhost device ctx to cuse It takes a bit while (by checking the code) that it's "ctx" triggers the warning. It could be spotted very quickly if "tx" is high lighted. This patch adds such support. Signed-off-by: Yuanhan Liu --- scripts/check-git-log.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh index b7ea1be..153f378 100755 --- a/scripts/check-git-log.sh +++ b/scripts/check-git-log.sh @@ -55,7 +55,7 @@ tags=$(git log --format='%b' $range | grep -i -e 'by *:' -e 'fix.*:') fixes=$(git log --format='%h %s' $range | grep -i ': *fix' | cut -d' ' -f1) # check headline format (spacing, no punctuation, no code) -bad=$(echo "$headlines" | grep \ +bad=$(echo "$headlines" | grep --color=always \ -e ' ' \ -e '^ ' \ -e ' $' \ @@ -69,7 +69,7 @@ bad=$(echo "$headlines" | grep \ [ -z "$bad" ] || printf "Wrong headline format:\n$bad\n" # check headline label for common typos -bad=$(echo "$headlines" | grep \ +bad=$(echo "$headlines" | grep --color=always \ -e '^example[:/]' \ -e '^apps/' \ -e '^testpmd' \ @@ -79,14 +79,14 @@ bad=$(echo "$headlines" | grep \ [ -z "$bad" ] || printf "Wrong headline label:\n$bad\n" # check headline lowercase for first words -bad=$(echo "$headlines" | grep \ +bad=$(echo "$headlines" | grep --color=always \ -e '^.*[A-Z].*:' \ -e ': *[A-Z]' \ | sed 's,^,\t,') [ -z "$bad" ] || printf "Wrong headline uppercase:\n$bad\n" # check headline uppercase (Rx/Tx, VF, L2, MAC, Linux, ARM...) -bad=$(echo "$headlines" | grep -E \ +bad=$(echo "$headlines" | grep -E --color=always \ -e '\<(rx|tx|RX|TX)\>' \ -e '\<[pv]f\>' \ -e '\' \ -- 1.9.0