From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6AF395A92 for ; Fri, 13 May 2016 07:20:03 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 12 May 2016 22:20:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,612,1455004800"; d="scan'208";a="805314613" Received: from yliu-dev.sh.intel.com ([10.239.67.162]) by orsmga003.jf.intel.com with ESMTP; 12 May 2016 22:20:00 -0700 From: Yuanhan Liu To: dev@dpdk.org Cc: Thomas Monjalon , huawei.xie@intel.com, Panu Matilainen , Tetsuya Mukawa , Traynor Kevin , Rich Lane , Yuanhan Liu Date: Thu, 12 May 2016 22:24:52 -0700 Message-Id: <1463117111-27050-1-git-send-email-yuanhan.liu@linux.intel.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1462227927-22853-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1462227927-22853-1-git-send-email-yuanhan.liu@linux.intel.com> Subject: [dpdk-dev] [PATCH v2 00/19] vhost ABI/API refactoring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2016 05:20:04 -0000 v2: - exported ifname as well to fix a vhost-pmd issue reported by Rich - separated the big patch that introduces several new APIs into some small patches. - updated release note - updated version.map NOTE: I created a branch at dpdk.org [0] for more conveinient testing: [0]: git://dpdk.org/next/dpdk-next-virtio for-testing Every time we introduce a new feature to vhost, we are likely to break ABI. Moreover, some cleanups (such as the one from Ilya to remove vec_buf from vhost_virtqueue struct) also break ABI. This patch set is meant to resolve above issue ultimately, by hiding virtio_net structure (as well as few others) internaly, and export the virtio_net dev strut to applications by a number, vid, like the way kernel exposes an fd to user space. Back to the patch set, the first part of this set makes some changes to vhost example, vhost-pmd and vhost, bit by bit, to remove the dependence to "virtio_net" struct. And then do the final change to make the current APIs to adapt to using "vid". After that, "vrtio_net_device_ops" is the only left open struct that an application can acces, therefore, it's the only place that might introduce potential ABI breakage in future for extension. Hence, I made few more (5) space reservation, to make sure we will not break ABI for a long time, and hopefuly, forever. The last bit of this patch set is some cleanups, including the one from Ilya. Note that this refactoring breaks the tep_termination example. Well, it's just another copy of the original messy vhost example, and I have no interest to cleanup it again. Therefore, I might consider to remove that example later, and add the vxlan bits into vhost example. Thanks. --yliu --- Ilya Maximets (1): vhost: make buf vector for scatter Rx local Yuanhan Liu (18): vhost: declare backend with int type vhost: set/reset dev flags internally vhost: declare device fh as int examples/vhost: make a copy of virtio device id vhost: rename device fh to vid vhost: get device by vid only vhost: move vhost device ctx to cuse vhost: introduce new API to export numa node vhost: introduce new API to export number of queues vhost: introduce new API to export ifname vhost: introduce new API to export queue free entries vhost: remove dependency on priv field vhost: export vid as the only interface to applications vhost: hide internal structs/macros/functions vhost: remove unnecessary fields vhost: remove virtio-net.h vhost: reserve few more space for future extension vhost: per device virtio net header len doc/guides/rel_notes/release_16_07.rst | 9 + drivers/net/vhost/rte_eth_vhost.c | 79 ++++----- examples/vhost/main.c | 124 +++++++------- examples/vhost/main.h | 1 + lib/librte_vhost/rte_vhost_version.map | 10 ++ lib/librte_vhost/rte_virtio_net.h | 223 +++++++------------------ lib/librte_vhost/vhost-net.h | 201 ++++++++++++++++++---- lib/librte_vhost/vhost_cuse/vhost-net-cdev.c | 83 +++++----- lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 30 ++-- lib/librte_vhost/vhost_cuse/virtio-net-cdev.h | 12 +- lib/librte_vhost/vhost_rxtx.c | 133 ++++++++------- lib/librte_vhost/vhost_user/vhost-net-user.c | 53 +++--- lib/librte_vhost/vhost_user/vhost-net-user.h | 2 + lib/librte_vhost/vhost_user/virtio-net-user.c | 64 +++---- lib/librte_vhost/vhost_user/virtio-net-user.h | 18 +- lib/librte_vhost/virtio-net.c | 229 +++++++++++++++++--------- lib/librte_vhost/virtio-net.h | 43 ----- 17 files changed, 702 insertions(+), 612 deletions(-) delete mode 100644 lib/librte_vhost/virtio-net.h -- 1.9.0