From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 612D42C6B for ; Tue, 24 May 2016 08:22:50 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 23 May 2016 23:22:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,359,1459839600"; d="scan'208";a="960998478" Received: from gklab-246-025.igk.intel.com (HELO Sent) ([10.217.246.25]) by orsmga001.jf.intel.com with SMTP; 23 May 2016 23:22:46 -0700 Received: by Sent (sSMTP sendmail emulation); Tue, 24 May 2016 09:25:35 +0200 From: Daniel Mrzyglod To: helin.zhang@intel.com, jingjing.wu@intel.com Cc: dev@dpdk.org, Daniel Mrzyglod Date: Tue, 24 May 2016 09:25:34 +0200 Message-Id: <1464074734-199475-1-git-send-email-danielx.t.mrzyglod@intel.com> X-Mailer: git-send-email 2.5.5 Subject: [dpdk-dev] [PATCH] i40e: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2016 06:22:50 -0000 Calling i40e_switch_rx_queue without checking return value. Fixed by add warning log information if return failed. Fixes: 71d35259ff67 ("i40e: tear down flow director") Coverity ID 13198 Signed-off-by: Daniel Mrzyglod --- drivers/net/i40e/i40e_fdir.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index 8aa41e5..ce6d916 100644 --- a/drivers/net/i40e/i40e_fdir.c +++ b/drivers/net/i40e/i40e_fdir.c @@ -288,12 +288,15 @@ i40e_fdir_teardown(struct i40e_pf *pf) { struct i40e_hw *hw = I40E_PF_TO_HW(pf); struct i40e_vsi *vsi; + int err = I40E_SUCCESS; vsi = pf->fdir.fdir_vsi; if (!vsi) return; i40e_switch_tx_queue(hw, vsi->base_queue, FALSE); - i40e_switch_rx_queue(hw, vsi->base_queue, FALSE); + err = i40e_switch_rx_queue(hw, vsi->base_queue, FALSE); + if (err) + PMD_DRV_LOG(WARNING, "Failed to do FDIR RX switch off."); i40e_dev_rx_queue_release(pf->fdir.rxq); pf->fdir.rxq = NULL; i40e_dev_tx_queue_release(pf->fdir.txq); -- 2.5.5