From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <h.mikita89@gmail.com>
Received: from mail-pa0-f67.google.com (mail-pa0-f67.google.com
[209.85.220.67]) by dpdk.org (Postfix) with ESMTP id 6B26E2BF1
for <dev@dpdk.org>; Wed, 25 May 2016 17:25:49 +0200 (CEST)
Received: by mail-pa0-f67.google.com with SMTP id gp3so5643228pac.2
for <dev@dpdk.org>; Wed, 25 May 2016 08:25:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
h=from:to:cc:subject:date:message-id:in-reply-to:references;
bh=B1mc74VEBVQ0nugWDGs+MJOZt/Oqpu25yklNYWWgWBs=;
b=UaFvkfqz/gknA1qsL+UtEgOGbu2d+4TnTgKOMR3S/uFRdqGU9aVsI0+2nuPXviUKUj
NyloJkYKT6Oy9uHrgqr0KTHQmT5hP0TwZZpOZFqSH51+rm9T4yIQ4BmZue3ypS3MQJ/9
IQ5YjEhM+x4WinXWNNT0UBe7uIK+WECJ/ZattGGv/m0ciHR3JAoTQ2UnrsGcIt3F2mPb
jL49oBggiw6Z6yDcQaaA0sHvZkGGkiBHJ+8GRiqED/FqIpV2DuC+WQfLU+fa84oN6W0q
eYjmv9cAudO6+I/H+Ixm2FTHQbhF47O8oV7KHCzXcMcX5DKmoFbkJKBdbI+QHgAv3nbg
G4vQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references;
bh=B1mc74VEBVQ0nugWDGs+MJOZt/Oqpu25yklNYWWgWBs=;
b=GxR3x4tWvoECNzce6QLyRDpn6gFTXokfB/i0XVb/On1w7rblhnmqEFLX8Uv3cje8V1
QA6v1RZCeTNyxmBcoCWB2IE7hwdGS6lbBqOpGg4eXK7Z17L3qPwtlqmWP3ox8oU0Mef0
od2rdWZkGmbBKOo5OG0tXDYmqMZxVLhLzfW3cESjSHF/nxNzVIxW9VSTqAZ5mARc2Sl5
Ktu0hW/fc04BgKn6/c3ZWeXhTK8Noy8xNj15Ichfa2sNLZ262ZAXHzkq4+qrqDD6XbmN
YyTnQ1XfP7efKwtFZGRz+6HBao4ytnuLWVDruVbeGm+snBAEDjPECR4Pw8SYrgROrsfr
bmZw==
X-Gm-Message-State: ALyK8tL+Vl6jYQvbyZ27UjYixba3LFbJUsYE/ICuDF3Q9hzg1qPerBbaFKr6g9g8SWdjlg==
X-Received: by 10.66.145.35 with SMTP id sr3mr6626585pab.82.1464189948710;
Wed, 25 May 2016 08:25:48 -0700 (PDT)
Received: from localhost.localdomain (183.180.67.214.ap.gmobb-fix.jp.
[183.180.67.214])
by smtp.gmail.com with ESMTPSA id uf5sm13632156pac.44.2016.05.25.08.25.47
(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
Wed, 25 May 2016 08:25:48 -0700 (PDT)
From: Hiroyuki Mikita <h.mikita89@gmail.com>
To: wenzhuo.lu@intel.com,
thomas.monjalon@6wind.com
Cc: dev@dpdk.org
Date: Thu, 26 May 2016 00:25:38 +0900
Message-Id: <1464189938-1769-1-git-send-email-h.mikita89@gmail.com>
X-Mailer: git-send-email 1.9.1
In-Reply-To: <1464101290-28547-1-git-send-email-h.mikita89@gmail.com>
References: <1464101290-28547-1-git-send-email-h.mikita89@gmail.com>
Subject: [dpdk-dev] [PATCH v2] e1000: fix build with clang
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 May 2016 15:25:49 -0000
GCC_VERSION is empty in case of clang:
/bin/sh: line 0: test: -ge: unary operator expected
It is the same issue as http://dpdk.org/dev/patchwork/patch/5994/
Fixes: 366113dbfb69 ("e1000: suppress misleading indentation warning")
Signed-off-by: Hiroyuki Mikita <h.mikita89@gmail.com>
---
v2:
* fix for cross compier
drivers/net/e1000/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile
index f4879e6..e845a8f 100644
--- a/drivers/net/e1000/Makefile
+++ b/drivers/net/e1000/Makefile
@@ -50,14 +50,16 @@ ifeq ($(CC), icc)
CFLAGS_BASE_DRIVER = -wd177 -wd181 -wd188 -wd869 -wd2259
else
#
-# CFLAGS for gcc
+# CFLAGS for gcc/clang
#
CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter
CFLAGS_BASE_DRIVER += -Wno-unused-variable
+ifeq ($(findstring gcc, $(CC)), gcc)
ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)
CFLAGS_BASE_DRIVER += -Wno-misleading-indentation
endif
endif
+endif
#
# Add extra flags for base driver files (also known as shared code)
--
1.9.1