From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <h.mikita89@gmail.com>
Received: from mail-pa0-f67.google.com (mail-pa0-f67.google.com
[209.85.220.67]) by dpdk.org (Postfix) with ESMTP id BC5AD374F
for <dev@dpdk.org>; Thu, 26 May 2016 13:36:49 +0200 (CEST)
Received: by mail-pa0-f67.google.com with SMTP id yl2so8727986pac.1
for <dev@dpdk.org>; Thu, 26 May 2016 04:36:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
h=from:to:cc:subject:date:message-id:in-reply-to:references;
bh=a6i2cban9trRH3mkYKBBgkjutTnSLD9WsavhelnZSbY=;
b=YutJKQ/LJ42+M38iogYDMNkeRK2+gysudMuOA4jJRaUVZ4DtpBT6H1zP8WS7cG9TsZ
M1XXU1r3wCyQ8b6Yu0lm7GoveiAe+tD39xOTjVAz6Dggs2kMZ8+oiZ4Y5FbZ2a1lJNS6
gyp6y4hjUd2PMhBypzq8b9cjGaoIU31M7do/3wtnRUfvr/YEN3lVRX5UgLjfPfdPU/pv
kFkhjfaRkWbV63+34arAAis7gXr2t6n4/nhKbbbyuSUNgU03TdwHDrroppxRQouqcDTK
eo8IAtDoX4wBakww6OikJvjmNdZDwuOaR8so7VfRLk8WPwO6hhxCrPDbq0QOZQT8CW2N
g8sw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references;
bh=a6i2cban9trRH3mkYKBBgkjutTnSLD9WsavhelnZSbY=;
b=E/OBWh0WBOSm8zE7h0H8SdEVPUrtvFUW3CXLHPTrwqtuNyro/w7sCs6BqdtsQiWo6p
ch5ZX8PUP8Qjy+nOSSGN5zqizQ1qLYPiT0Y5mllFbcTQgYw6/PmA9N3phZsDDd35I3VS
z9jy2RQLEHWLTAsER5X6I7fLdaJYnjEWF9ILUu4dU2A1fir131GU8gJEKUfBVMpGdxKm
jq5DmAxADbPw4TshJPvLJAK4QxARAKEp3aIeknGP4kloKa1HDnFmMXOnqMcMUCxAxkXK
XPSaeFtAW5ugiw4UE5S59lV9CLCEe1I7ULoxD6Mvc0bmUmo1z+fP03BzJGlMwmCaJPoW
q6eQ==
X-Gm-Message-State: ALyK8tJTGBAZp2isW4YYEzGzFdVirincPKWzWoraZGqQqhSok99jni24ugvKr0MB2T2jiw==
X-Received: by 10.66.66.234 with SMTP id i10mr13579527pat.114.1464262608971;
Thu, 26 May 2016 04:36:48 -0700 (PDT)
Received: from localhost.localdomain (183.180.67.214.ap.gmobb-fix.jp.
[183.180.67.214])
by smtp.gmail.com with ESMTPSA id j192sm5495901pfc.25.2016.05.26.04.36.47
(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
Thu, 26 May 2016 04:36:48 -0700 (PDT)
From: Hiroyuki Mikita <h.mikita89@gmail.com>
To: wenzhuo.lu@intel.com,
thomas.monjalon@6wind.com
Cc: dev@dpdk.org
Date: Thu, 26 May 2016 20:36:39 +0900
Message-Id: <1464262599-28717-1-git-send-email-h.mikita89@gmail.com>
X-Mailer: git-send-email 1.9.1
In-Reply-To: <1464189938-1769-1-git-send-email-h.mikita89@gmail.com>
References: <1464189938-1769-1-git-send-email-h.mikita89@gmail.com>
Subject: [dpdk-dev] [PATCH v3] e1000: fix build with clang
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 May 2016 11:36:50 -0000
GCC_VERSION is empty in case of clang:
/bin/sh: line 0: test: -ge: unary operator expected
It is the same issue as http://dpdk.org/dev/patchwork/patch/5994/
Fixes: 366113dbfb69 ("e1000: suppress misleading indentation warning")
Signed-off-by: Hiroyuki Mikita <h.mikita89@gmail.com>
---
v3:
* use CONFIG_RTE_TOOLCHAIN_GCC
v2:
* fix for cross compier
drivers/net/e1000/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile
index f4879e6..b5b803e 100644
--- a/drivers/net/e1000/Makefile
+++ b/drivers/net/e1000/Makefile
@@ -50,14 +50,16 @@ ifeq ($(CC), icc)
CFLAGS_BASE_DRIVER = -wd177 -wd181 -wd188 -wd869 -wd2259
else
#
-# CFLAGS for gcc
+# CFLAGS for gcc/clang
#
CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter
CFLAGS_BASE_DRIVER += -Wno-unused-variable
+ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)
CFLAGS_BASE_DRIVER += -Wno-misleading-indentation
endif
endif
+endif
#
# Add extra flags for base driver files (also known as shared code)
--
1.9.1