From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 541665958 for ; Mon, 30 May 2016 13:56:52 +0200 (CEST) Received: from glumotte.dev.6wind.com (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id 3121423F7D; Mon, 30 May 2016 13:56:52 +0200 (CEST) From: Olivier Matz To: dev@dpdk.org Cc: thomas.monjalon@6wind.com, helin.zhang@intel.com Date: Mon, 30 May 2016 13:56:46 +0200 Message-Id: <1464609406-23152-1-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.8.0.rc3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] kni: fix use of undefined comma variable in makefile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 May 2016 11:56:52 -0000 The $(comma) variable is not defined in this Makefile, nor in any included Makefile. Seen while doing a "make clean" on ubuntu: $ make clean == Clean lib == Clean lib/librte_compat == Clean lib/librte_eal == Clean lib/librte_eal/common == Clean lib/librte_eal/linuxapp == Clean lib/librte_eal/linuxapp/eal == Clean lib/librte_eal/linuxapp/igb_uio == Clean lib/librte_eal/linuxapp/kni tr: missing operand after ‘.-’ Two strings must be given when translating. Try 'tr --help' for more information. This commit replaces $(comma) by a ',' character, it's not a problem in that case since we are inside antiquotes. Fixes: a09b359daca3 ("kni: fix build on Ubuntu 14.04") Signed-off-by: Olivier Matz --- lib/librte_eal/linuxapp/kni/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/kni/Makefile b/lib/librte_eal/linuxapp/kni/Makefile index ac99d3f..8cc6b61 100644 --- a/lib/librte_eal/linuxapp/kni/Makefile +++ b/lib/librte_eal/linuxapp/kni/Makefile @@ -47,7 +47,7 @@ MODULE_CFLAGS += -Wall -Werror ifeq ($(shell lsb_release -si 2>/dev/null),Ubuntu) MODULE_CFLAGS += -DUBUNTU_RELEASE_CODE=$(shell lsb_release -sr | tr -d .) UBUNTU_KERNEL_CODE := $(shell echo `grep UTS_RELEASE $(RTE_KERNELDIR)/include/generated/utsrelease.h \ - | cut -d '"' -f2 | cut -d- -f1,2 | tr .- $(comma)`,1) + | cut -d '"' -f2 | cut -d- -f1,2 | tr .- ,`,1) MODULE_CFLAGS += -D"UBUNTU_KERNEL_CODE=UBUNTU_KERNEL_VERSION($(UBUNTU_KERNEL_CODE))" endif -- 2.8.0.rc3