From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f47.google.com (mail-lf0-f47.google.com [209.85.215.47]) by dpdk.org (Postfix) with ESMTP id 541EF2BF7 for ; Wed, 1 Jun 2016 09:56:26 +0200 (CEST) Received: by mail-lf0-f47.google.com with SMTP id w16so7177594lfd.2 for ; Wed, 01 Jun 2016 00:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vMoRI3K4mbKoozuvOJEjVBDqSwnH1A2wezCPvp9FJog=; b=v3I2ESgTsMqLQfuAPbkULeyl2utlyprm2z/QWsNuAbOv2xrxkGSbJticEEsFK+8KlS Uqhp/pe4lU+Zoba5XqmC1t7Jf7M0xNcYZoJrOUGWOeTSQm07LPaLEuUDurPhX+UNWOxN kNc2ApMM4eZQoCSPAN3Z0z+0Xqxm9o5zeTfuTgbmWAd37h/4h0RlTVcAYRd9Z7vdp+eX UzKeEraYKPWp7uM2OcHZHE2cssOuBN0ZJ92jG7DpQiUGmkm6cilokP1fom0M76nyy3oa uPqFWCQwjP1oSMcAXMcruub6WWUhfBdWK73qC/A60k88Zp3p2UtQ0OMUUY3lA4kH5AtG kvXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vMoRI3K4mbKoozuvOJEjVBDqSwnH1A2wezCPvp9FJog=; b=ik8/0fBKxr66xhxqIqQRmCxe2cLif+Z4HPnvFXKoTsKJ0j2yFy3A3/8Etkg838uUzK hOAIpOMbLZw8LhswsmPMUQkloqGsxEuf2J9ezUN9JLCYfTdEyIfu3NGEXLhPJVVYov16 aU0F0ZvOY8KUOxjRQo3VB/MDiu5Pm9xrtHEg+pmlCt+UERrCQ/8OMDrO6FxkbFCfg2kz blZvfCBmYWBNhtPCFTm512IZVQ92t312uOTE/MGutPBzZufthkYqiXIHqwktCF4XSeYH VANin2Nnahp0hRSgoxr+QkWpoSz8VHj2QP/vMk+WG/lv0OF+WSobktFHH/z1Pr1gf9+P aTYA== X-Gm-Message-State: ALyK8tKu5FUutMgsG2IOFIkLrSHpnkMH45kx/IioNW+QfokVmEstKZkFrY89sUJIeVpFDg== X-Received: by 10.46.0.222 with SMTP id e91mr968526lji.57.1464767786046; Wed, 01 Jun 2016 00:56:26 -0700 (PDT) Received: from zr-HP-Pro-3500-Series.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id 72sm3372298ljj.0.2016.06.01.00.56.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 01 Jun 2016 00:56:25 -0700 (PDT) From: zr@semihalf.com To: remy.horton@intel.com, thomas.monjalon@6wind.com Cc: dev@dpdk.org, Zyta Szpak Date: Wed, 1 Jun 2016 09:56:11 +0200 Message-Id: <1464767771-19159-2-git-send-email-zr@semihalf.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464767771-19159-1-git-send-email-zr@semihalf.com> References: <1464767771-19159-1-git-send-email-zr@semihalf.com> Subject: [dpdk-dev] [PATCH v3 2/2] examples/ethtool: get reg width to allocate memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2016 07:56:26 -0000 From: Zyta Szpak Version 2 of fixing the fixed register width assumption. Not every device uses 32-bit wide register. The app was allocating too little space for 64-bit registers which resulted in memory corruption. This commit resolves this by getting the size of register in bytes for a specific device. If the device does not implement this function, it fallsback to sizeof(uint32_t) Signed-off-by: Zyta Szpak --- examples/ethtool/lib/rte_ethtool.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c index 42e05f1..59191ca 100644 --- a/examples/ethtool/lib/rte_ethtool.c +++ b/examples/ethtool/lib/rte_ethtool.c @@ -88,10 +88,14 @@ int rte_ethtool_get_regs_len(uint8_t port_id) { int count_regs; + int reg_width; count_regs = rte_eth_dev_get_reg_length(port_id); + reg_width = rte_eth_dev_get_reg_width(port_id); + if (reg_width < 0) + reg_width = sizeof(uint32_t); if (count_regs > 0) - return count_regs * sizeof(uint32_t); + return count_regs * reg_width; return count_regs; } -- 1.9.1