From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
by dpdk.org (Postfix) with ESMTP id 91C562BBD
for <dev@dpdk.org>; Fri, 3 Jun 2016 10:15:28 +0200 (CEST)
Received: by mail-wm0-f48.google.com with SMTP id a136so264160131wme.0
for <dev@dpdk.org>; Fri, 03 Jun 2016 01:15:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id;
bh=7Z24Dv5Oqlb8tznT2/rFyQ5zWcyykyuoHXHv7Bx0EZ8=;
b=HsNxOwHBLhbYGCjmQhAbSz6FDSW6Dd1ifYRz3T1SNsXLwTAonTOjLqNI2khGjgKDpR
mplMqvNqqk3pV3X9t6fp8cIXk3GzQjOFMjOXnAg3wO7H2BTWaikks0U8jmdltYTGq1fS
vRzVFkm00awYNtV0vcud0elGnhdb0QE9alXBE3ydcEiRcoZcQLHfl6EB06kS0DLvEKzm
vcItsgdxPH0HbN2iMVtWdgD07TqzUteWyUNavwdK5dfi67u71qD8ArsLKR7Cd3wf8qjb
XwSJsZ/2wmze+NV9bsA3iu+VUvoyZQWyCUrgUvWkNHF9wCx2t584H2YhzHvXRvWJv+pw
pGng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id;
bh=7Z24Dv5Oqlb8tznT2/rFyQ5zWcyykyuoHXHv7Bx0EZ8=;
b=kjIezP9vvx8cuToFXchr4g8MGGi8KtA0h5QJMyo3vZn99oaHkf56gDQbvq30VWZxpO
ipfXZWJd5sw6ehw8BDotyZsRcCECYUVK7Z3WMf4KClLb0I8jU/GdX+jd4G4ZSgcRuq6G
ohoRAsAnmJVDpJwjJ+F//fn9QtjKRKtiDkcjN9YagzkMre1K7mKpQuaIkP3h1+CnrxfS
0R20CZiwx1UNLcaQoJmzabEldOBPOLH5TppylBZub2W9Rt7/syF0JebayQ1O59/13C87
ZnZaLQtyD3xbpPRThckxDf7NfgDy1FA6TwKVovMsA6Dt5f3H9l2mwHpEQ57M0cnxrSKB
Cn6w==
X-Gm-Message-State: ALyK8tIYcUmWCzpJwjF7VhC5wrrCDwaOCSYmXY24h9puBkDi7//ObUjkltjfrS8r+yYfMdhx
X-Received: by 10.194.103.105 with SMTP id fv9mr2107484wjb.162.1464941728311;
Fri, 03 Jun 2016 01:15:28 -0700 (PDT)
Received: from XPS13.enst.fr ([2001:660:330f:38:7e7a:91ff:fe14:f0d2])
by smtp.gmail.com with ESMTPSA id s1sm799770wjf.43.2016.06.03.01.15.26
(version=TLSv1/SSLv3 cipher=OTHER);
Fri, 03 Jun 2016 01:15:27 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Cc: Damjan Marion <damarion@cisco.com>
Date: Fri, 3 Jun 2016 10:15:23 +0200
Message-Id: <1464941723-18154-1-git-send-email-thomas.monjalon@6wind.com>
X-Mailer: git-send-email 2.7.0
Subject: [dpdk-dev] [PATCH] eal/x86: fix clang build with -O0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jun 2016 08:15:28 -0000
From: Damjan Marion <damarion@cisco.com>
Clang seems to have a bug with asm inside inline function rte_xabort():
rte_rtm.h:56:15: error: invalid operand for inline asm constraint 'i'
asm volatile(".byte 0xc6,0xf8,%P0" :: "i" (status) : "memory");
^
It is seen only when building with EXTRA_CFLAGS=-O0.
The workaround is to replace the inline function by a macro.
Fixes: ba7468997ea6 ("spinlock: add HTM lock elision for x86")
Signed-off-by: Damjan Marion <damarion@cisco.com>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
lib/librte_eal/common/include/arch/x86/rte_rtm.h | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/lib/librte_eal/common/include/arch/x86/rte_rtm.h b/lib/librte_eal/common/include/arch/x86/rte_rtm.h
index d935641..0649f79 100644
--- a/lib/librte_eal/common/include/arch/x86/rte_rtm.h
+++ b/lib/librte_eal/common/include/arch/x86/rte_rtm.h
@@ -50,11 +50,10 @@ void rte_xend(void)
asm volatile(".byte 0x0f,0x01,0xd5" ::: "memory");
}
-static __attribute__((__always_inline__)) inline
-void rte_xabort(const unsigned int status)
-{
- asm volatile(".byte 0xc6,0xf8,%P0" :: "i" (status) : "memory");
-}
+/* not an inline function to workaround a clang bug with -O0 */
+#define rte_xabort(status) do { \
+ asm volatile(".byte 0xc6,0xf8,%P0" :: "i" (status) : "memory"); \
+} while (0)
static __attribute__((__always_inline__)) inline
int rte_xtest(void)
--
2.7.0