From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 0E988ADE8 for ; Wed, 8 Jun 2016 11:48:40 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id v199so55430465wmv.0 for ; Wed, 08 Jun 2016 02:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lJPCOdWStJvY2u8tH8EWIH1mXfe8cOGsbRJoVhj1GXo=; b=UznnE/+qnUMIQuW6e1zAdesigxpXufa2npsRYAPbt0O/rMZxn+IMt8Aup2HyOgp13/ dtA1qi1rocgIZClsuqkSYqNKFedAzKO1sI2HNDA0aUYG9g1gRnpMlQYMHmmdE3w4o95K E2z8oDJCU2hXX13Tsv5Zy1SAd2qrMckCiMtqQ4v/NpZfozfd3xmUAWM94gWH1ih4j7H1 jVl5E0Gtbw/Q+Bgh0PztMXCzWkMxkIdl64/+b85sVpNOg+2kRXXzOGBhD05aP6mX2fnw caYG9td/sbfG6ay7Xk496RwKTcTXlMtKVay9zhC+10edbRc7XZHIP7fNiqv8ZsR2O5U1 LsoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lJPCOdWStJvY2u8tH8EWIH1mXfe8cOGsbRJoVhj1GXo=; b=eJTK2a2Q94P5f/IFV5vK45PO2EvG24yMpLZXW+wrHDsuGO06j7l4IHtJf5oYGdpFTt ipS3H7cB+kCWWafyjIWB+6M7JJI6GiapV6DfEF+pJwvbkQ23wudhV5z4MgcfBxG8iN2O BwV9Tcarcid6yWHX4G8EmgzcwHdvmdrG+JVjkMpR8SAypeHIknsKErWOKyPvJAaFZe/v 1cVn6RwYClpbaLkZxWjmR7rK9C9i48r07cuisJtdjyhWvhkYwC/wKXS1yknJgTE/VHis ThjrXVakV7fB8HIYclXEBmuDxSzRiv1s0pWc6fjxUwAVYvf9ooHtwGjvcgSCWYYli+e6 HwpQ== X-Gm-Message-State: ALyK8tI0B5gxyCuRVaaTpsm2aJAp0QP3LkKCcxpBI0x/lUJRULyKcp2M7EWuoaHQZ6qevQuh X-Received: by 10.194.188.116 with SMTP id fz20mr3540144wjc.163.1465379319783; Wed, 08 Jun 2016 02:48:39 -0700 (PDT) Received: from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id c185sm23899214wme.9.2016.06.08.02.48.39 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 08 Jun 2016 02:48:39 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Adrien Mazarguil Date: Wed, 8 Jun 2016 11:48:09 +0200 Message-Id: <1465379291-25310-23-git-send-email-nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1465379291-25310-1-git-send-email-nelio.laranjeiro@6wind.com> References: <1465379291-25310-1-git-send-email-nelio.laranjeiro@6wind.com> Subject: [dpdk-dev] [PATCH 22/24] mlx5: remove redundant RX queue initialization code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2016 09:48:40 -0000 From: Adrien Mazarguil Toggling RX checksum offloads is already done at initialization time. This code does not belong in rxq_rehash(). Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_rxq.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index b3972ff..20a236e 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -798,7 +798,6 @@ rxq_cleanup(struct rxq_ctrl *rxq_ctrl) int rxq_rehash(struct rte_eth_dev *dev, struct rxq_ctrl *rxq_ctrl) { - struct priv *priv = rxq_ctrl->priv; struct rxq_ctrl tmpl = *rxq_ctrl; unsigned int mbuf_n; unsigned int desc_n; @@ -811,15 +810,6 @@ rxq_rehash(struct rte_eth_dev *dev, struct rxq_ctrl *rxq_ctrl) /* Number of descriptors and mbufs currently allocated. */ desc_n = tmpl.rxq.elts_n; mbuf_n = desc_n; - /* Toggle RX checksum offload if hardware supports it. */ - if (priv->hw_csum) { - tmpl.rxq.csum = !!dev->data->dev_conf.rxmode.hw_ip_checksum; - rxq_ctrl->rxq.csum = tmpl.rxq.csum; - } - if (priv->hw_csum_l2tun) { - tmpl.rxq.csum_l2tun = !!dev->data->dev_conf.rxmode.hw_ip_checksum; - rxq_ctrl->rxq.csum_l2tun = tmpl.rxq.csum_l2tun; - } /* From now on, any failure will render the queue unusable. * Reinitialize WQ. */ mod = (struct ibv_exp_wq_attr){ -- 2.1.4