From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 9ACEC5955 for ; Mon, 13 Jul 2015 12:47:31 +0200 (CEST) Received: by wicmv11 with SMTP id mv11so58221739wic.1 for ; Mon, 13 Jul 2015 03:47:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=/FcuU7epIwK8rceKQV8czUIyFL+XtCgtIwaHacMjtJg=; b=jplUzOABm1aWO65/a4nFgy+wxHtUIa7UhA0CXpDVY/cSJyCvn7faeNWB9h/FZvLkVH LMZ+wchGlks11A70eFKA+4evvPQImkPT8qnBiqAfLUo851rf9uRL0dZWwmFDUssuf8wl drqbCzIIv2yDKx6tVd5QtYi0ni7YId/J1cc2qD9vApIzoB+831zl8Uz2CqGgI2LFgdy7 VbtoApeuC+m6B7+sFhcW9yFo9pq3PA12hH4TGWQea9OgBrMM9WMiU+XGsAAJHAENVcNB 5Cd0VSBO5aYPuJ5MQp8FtfH24TuVA7iDOyZmVi2wQDq1ZEBkeXGjPzW8amxYm4R14ZcU peWw== X-Gm-Message-State: ALoCoQn8p63F9y/XFNLkg+UrBZXTCJogdnbmA/ASSTGvqiIHYJzO+Qkh8DYb5jVYB2fE1RtYOMlq X-Received: by 10.194.205.225 with SMTP id lj1mr64273303wjc.138.1436784451538; Mon, 13 Jul 2015 03:47:31 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id lu5sm28468412wjb.9.2015.07.13.03.47.29 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jul 2015 03:47:30 -0700 (PDT) From: Thomas Monjalon To: Chao Zhu Date: Mon, 13 Jul 2015 12:46:17 +0200 Message-ID: <1465595.fVxK4oazvN@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <20150713104218.GB9631@hmsreliant.think-freely.org> References: <1436783185-8279-1-git-send-email-john.mcnamara@intel.com> <20150713104218.GB9631@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2015 10:47:31 -0000 2015-07-13 06:42, Neil Horman: > On Mon, Jul 13, 2015 at 11:26:25AM +0100, John McNamara wrote: > > Fix for ABI breakage introduced in LRO addition. Moves > > lro bitfield to the end of the struct/member. > > > > Fixes: 8eecb3295aed (ixgbe: add LRO support) > > > > Signed-off-by: John McNamara > > --- > > lib/librte_ether/rte_ethdev.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > > index 79bde89..1c3ace1 100644 > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -1578,9 +1578,9 @@ struct rte_eth_dev_data { > > uint8_t port_id; /**< Device [external] port identifier. */ > > uint8_t promiscuous : 1, /**< RX promiscuous mode ON(1) / OFF(0). */ > > scattered_rx : 1, /**< RX of scattered packets is ON(1) / OFF(0) */ > > - lro : 1, /**< RX LRO is ON(1) / OFF(0) */ > > all_multicast : 1, /**< RX all multicast mode ON(1) / OFF(0). */ > > - dev_started : 1; /**< Device state: STARTED(1) / STOPPED(0). */ > > + dev_started : 1, /**< Device state: STARTED(1) / STOPPED(0). */ > > + lro : 1; /**< RX LRO is ON(1) / OFF(0) */ > > }; > > > > /** > I presume the ABI checker stopped complaining about this with the patch, yes? > > Also, it would be great if someone could check this on ppc or a ppc cross > compile, as I recall bitfields follow endianess order. + Chao, IBM POWER maintainer.