From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6C4008E56 for ; Mon, 20 Jun 2016 15:49:42 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 20 Jun 2016 06:49:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,498,1459839600"; d="scan'208";a="979641479" Received: from rhorton-mobl.ger.corp.intel.com (HELO VM.ir.intel.com) ([163.33.228.132]) by orsmga001.jf.intel.com with ESMTP; 20 Jun 2016 06:49:38 -0700 From: Remy Horton To: pablo.de.lara.guarch@intel.com Cc: dev@dpdk.org Date: Mon, 20 Jun 2016 14:49:38 +0100 Message-Id: <1466430578-1224-1-git-send-email-remy.horton@intel.com> X-Mailer: git-send-email 2.5.5 Subject: [dpdk-dev] [PATCH v1] app: fix Coverity issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2016 13:49:42 -0000 Fixes memory leaks detected by Coverity. These are due to ephemeral memory allocations not being freed when errors occur. Coverity issue 127348: Resource leak Coverity issue 127349: Resource leak Fixes: e2aae1c1ced9 ("ethdev: remove name from extended statistic fetch") Signed-off-by: Remy Horton --- app/test-pmd/config.c | 3 +++ examples/l2fwd-keepalive/shm.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 10f0a36..cb71c09 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -281,6 +281,7 @@ nic_xstats_display(portid_t port_id) if (cnt_xstats != rte_eth_xstats_get_names( port_id, xstats_names, cnt_xstats)) { printf("Error: Cannot get xstats lookup\n"); + free(xstats_names); return; } @@ -293,6 +294,8 @@ nic_xstats_display(portid_t port_id) } if (cnt_xstats != rte_eth_xstats_get(port_id, xstats, cnt_xstats)) { printf("Error: Unable to get xstats\n"); + free(xstats_names); + free(xstats); return; } diff --git a/examples/l2fwd-keepalive/shm.c b/examples/l2fwd-keepalive/shm.c index 66fc433..177aa5b 100644 --- a/examples/l2fwd-keepalive/shm.c +++ b/examples/l2fwd-keepalive/shm.c @@ -80,6 +80,8 @@ struct rte_keepalive_shm *rte_keepalive_shm_create(void) RTE_LOG(INFO, EAL, "Failed to setup SHM semaphore (%s)\n", strerror(errno)); + munmap(ka_shm, + sizeof(struct rte_keepalive_shm)); return NULL; } -- 2.5.5