From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 663DBC690 for ; Fri, 24 Jun 2016 10:54:01 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id v199so14011880wmv.0 for ; Fri, 24 Jun 2016 01:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VZhx3f5AxSV8zSPJHCpB8wLIAgM+GJqpcLZ8lZV2V4I=; b=rFCCf6HuAuQmaSNSaSmKpEfk+nqiXeGAVb14rGVHbvvIB6qJvTdsqY1fMqGfaQe/OK CZVIz7x1NaKCaEHT7EPxqwtA6KXhEQhoPPle/8JI8avXoEg2MV2B2D4TOFVOI0Wli231 zjQruiH3x2kIj0GWwNKYYJQyAXwUN1d84BLbUgthGVE3OSW4jokIagPT6+ZDRcEI6u8E eegHsOGG8A33ApkQCIpKXzHcqlmujK+ZP1i4bjCeLph7LT30x1QA3cO0g0uMQbTFYTXG ia2cnhGM9sddAcZ8reqQbLvm6gAwHqNMK2u2oYEm280/O4EYDVwBq5pUUCjmqTuOiWa6 E4ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VZhx3f5AxSV8zSPJHCpB8wLIAgM+GJqpcLZ8lZV2V4I=; b=lh1KoH+9jOl18QPdmEBoMMbPRoYYtbQI1JXsa6cAhwEHm5XqYbbpfB5mV5ZVYMiO+H jGGQR8W30Em38dkuOf/BtBM8rz4USPgqnqez0gpOqUYYj99e4nvo88fmF0wwJPeMadvL wd0kUitvpQn0Ar/jQAaRn20CZW5ibjgtp3Bzj7dvtVq3ZnDOCVAVO6uozu/e7Wr/SonB 90f7y179Ln/sYaiHRh3HTXrO4mVxWm6lGHjuEUN4CxMDW5lB7SxvAxBdjwSskXrjeLQJ x9qOOlMCQz9UjpDBehasr4f0KACHGN9K8RWLVvIIReXUHhRQWoigTspBydCwVYvY1kV7 I5mg== X-Gm-Message-State: ALyK8tIgohvzn7EJ1P3A8Wer93ebGVa8l0sJau0aWtmp27Wvb6VvhVPiDvINydv/sYRTeLga X-Received: by 10.194.114.163 with SMTP id jh3mr2887851wjb.173.1466758441227; Fri, 24 Jun 2016 01:54:01 -0700 (PDT) Received: from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id t188sm2060584wma.8.2016.06.24.01.54.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 24 Jun 2016 01:54:00 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Bruce Richardson , Ferruh Yigit , Adrien Mazarguil Date: Fri, 24 Jun 2016 10:50:59 +0200 Message-Id: <1466758261-25986-24-git-send-email-nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1466758261-25986-1-git-send-email-nelio.laranjeiro@6wind.com> References: <1466700801-10383-1-git-send-email-nelio.laranjeiro@6wind.com> <1466758261-25986-1-git-send-email-nelio.laranjeiro@6wind.com> Subject: [dpdk-dev] [PATCH v6 23/25] mlx5: remove redundant Rx queue initialization code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2016 08:54:01 -0000 From: Adrien Mazarguil Toggling RX checksum offloads is already done at initialization time. This code does not belong in rxq_rehash(). Signed-off-by: Adrien Mazarguil Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxq.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index b2f8f9a..fbf14fa 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -798,7 +798,6 @@ rxq_cleanup(struct rxq_ctrl *rxq_ctrl) int rxq_rehash(struct rte_eth_dev *dev, struct rxq_ctrl *rxq_ctrl) { - struct priv *priv = rxq_ctrl->priv; struct rxq_ctrl tmpl = *rxq_ctrl; unsigned int mbuf_n; unsigned int desc_n; @@ -811,16 +810,6 @@ rxq_rehash(struct rte_eth_dev *dev, struct rxq_ctrl *rxq_ctrl) /* Number of descriptors and mbufs currently allocated. */ desc_n = tmpl.rxq.elts_n; mbuf_n = desc_n; - /* Toggle RX checksum offload if hardware supports it. */ - if (priv->hw_csum) { - tmpl.rxq.csum = !!dev->data->dev_conf.rxmode.hw_ip_checksum; - rxq_ctrl->rxq.csum = tmpl.rxq.csum; - } - if (priv->hw_csum_l2tun) { - tmpl.rxq.csum_l2tun = - !!dev->data->dev_conf.rxmode.hw_ip_checksum; - rxq_ctrl->rxq.csum_l2tun = tmpl.rxq.csum_l2tun; - } /* From now on, any failure will render the queue unusable. * Reinitialize WQ. */ mod = (struct ibv_exp_wq_attr){ -- 2.1.4