From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 9E188C6C2 for ; Fri, 24 Jun 2016 15:18:56 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id f126so22248605wma.1 for ; Fri, 24 Jun 2016 06:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=F02xUWhvBUFzGRU+1LLKi9OwE1HrV9E0fU2pj2QFoLg=; b=VtB/WpcEKFOQ+k5hvggTC6PkhNFhhKwrxeMbHhWzfrshBKR3EGSlfH4scKnOnkfVzt t0xzQbZ+GpZUGgdeTULtY9sjO8X2wTQFGUvSZEBei1TtcwKNEQE3+85KYHXevlyaZza/ gcYjpLXySbhEx3uFqZgk5JZhBsAWiC9wdNIEYX0XqolIpLpWPeLHffZxo6jhB0rSliAg rc8mn2d/X8uSrDKrdDk6Wq/8BwxghKEU6hdbd6S8GL9vwBOfe8t8lekQNMJaLo4TbpuO Dv5G8T46C/EqgF3Np5lHT0kXBiNvyvpdzCV5kCMBRmGkB46UGdf9yUziyMQ4IChmgFKH Pzug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=F02xUWhvBUFzGRU+1LLKi9OwE1HrV9E0fU2pj2QFoLg=; b=gnkU3LDPuJH4P7IrdoQw1gOFzeD2SvFNpsyxRoYF8JAFw13nBaFKEbKPE5Tr1OOCUa vbvT474sTjDJ0ldOQxfxH5Zjin9KqHUK/V/5aIr8cKx7JiX6Iud4tlddKKEDmIM+BWsb jMnbmephIAXsQIxqmo7wL9okwBMOidYMlMrkL2TxyJDZAsD82mn8LcKzRbqr01KEU9Y9 05likdju2xXAUruLkNmLB5+X270HLFyS1Q2MJDvMi3t5pEC1yNPeSZfzztDMRQ02VuQf E9XOHG0IWAWfzydDG4mYMQWPBdBwrSwIdr/SweVwdW4xBxVDbryJM1tgsBet4D4fT/Hd aW5w== X-Gm-Message-State: ALyK8tJ3JpkQxAf0PA7J7uh2Xxz2UksNxsvOWrr8xTXPK26oLczNu+od3yqp4DN2EyOSJrcv X-Received: by 10.28.95.196 with SMTP id t187mr19206154wmb.89.1466774336413; Fri, 24 Jun 2016 06:18:56 -0700 (PDT) Received: from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id m125sm1279533wmm.8.2016.06.24.06.18.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 24 Jun 2016 06:18:55 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Bruce Richardson , Ferruh Yigit , Adrien Mazarguil Date: Fri, 24 Jun 2016 15:17:50 +0200 Message-Id: <1466774284-20932-12-git-send-email-nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1466774284-20932-1-git-send-email-nelio.laranjeiro@6wind.com> References: <1466758261-25986-1-git-send-email-nelio.laranjeiro@6wind.com> <1466774284-20932-1-git-send-email-nelio.laranjeiro@6wind.com> Subject: [dpdk-dev] [PATCH v7 11/25] mlx5: add support for configuration through kvargs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2016 13:18:56 -0000 The intent is to replace the remaining compile-time options and environment variables with a common mean of runtime configuration. This commit only adds the kvargs handling code, subsequent commits will update the rest. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 73 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 3f45d84..d08d4ac 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -37,6 +37,7 @@ #include #include #include +#include #include /* Verbs header. */ @@ -57,6 +58,7 @@ #include #include #include +#include #ifdef PEDANTIC #pragma GCC diagnostic error "-pedantic" #endif @@ -237,6 +239,71 @@ mlx5_dev_idx(struct rte_pci_addr *pci_addr) return ret; } +/** + * Verify and store value for device argument. + * + * @param[in] key + * Key argument to verify. + * @param[in] val + * Value associated with key. + * @param opaque + * User data. + * + * @return + * 0 on success, negative errno value on failure. + */ +static int +mlx5_args_check(const char *key, const char *val, void *opaque) +{ + struct priv *priv = opaque; + + /* No parameters are expected at the moment. */ + (void)priv; + (void)val; + WARN("%s: unknown parameter", key); + return -EINVAL; +} + +/** + * Parse device parameters. + * + * @param priv + * Pointer to private structure. + * @param devargs + * Device arguments structure. + * + * @return + * 0 on success, errno value on failure. + */ +static int +mlx5_args(struct priv *priv, struct rte_devargs *devargs) +{ + const char **params = (const char *[]){ + NULL, + }; + struct rte_kvargs *kvlist; + int ret = 0; + int i; + + if (devargs == NULL) + return 0; + /* Following UGLY cast is done to pass checkpatch. */ + kvlist = rte_kvargs_parse(devargs->args, params); + if (kvlist == NULL) + return 0; + /* Process parameters. */ + for (i = 0; (params[i] != NULL); ++i) { + if (rte_kvargs_count(kvlist, params[i])) { + ret = rte_kvargs_process(kvlist, params[i], + mlx5_args_check, priv); + if (ret != 0) + return ret; + } + } + rte_kvargs_free(kvlist); + return 0; +} + static struct eth_driver mlx5_driver; /** @@ -408,6 +475,12 @@ mlx5_pci_devinit(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) priv->port = port; priv->pd = pd; priv->mtu = ETHER_MTU; + err = mlx5_args(priv, pci_dev->devargs); + if (err) { + ERROR("failed to process device arguments: %s", + strerror(err)); + goto port_error; + } if (ibv_exp_query_device(ctx, &exp_device_attr)) { ERROR("ibv_exp_query_device() failed"); goto port_error; -- 2.1.4