From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 8C17868F0 for ; Sun, 26 Jun 2016 18:42:15 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id r201so84873404wme.1 for ; Sun, 26 Jun 2016 09:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MJYcpG6U4vugXY+240t/liem7xgdebUukCXQIaNx/CI=; b=WtmDsmLcHNbPs/rt/t3xvMErP6D2KOK8RXj+LIGZfB4GurRQ1vsrZESEgFnWFvYobm f8DOfit7HrQ1+H8VmUFQJHv0QoEtpszjLaQISOHKqwBggOILoSufSx3rnZnhV+gBP6Gz zeMJ4q4pR4Bb0A6i1WrbqsVFu4ojcznZTPgFlazcWcsU4eimEH3+3Krq2sgOT6FpBzLO rRi2VWVa1cAz9Oc2DYdX9EKDyuj0m3FP1ugHGaDEwoG5f1HvyUdZMukDUHZ1ELRt+6h+ NlS1cLc7Qo43IAOajiDqvlwWkurxlduciMpYZ292qkxHKHvnkgPjNErNHnQ2VZvVPfZA +gDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MJYcpG6U4vugXY+240t/liem7xgdebUukCXQIaNx/CI=; b=hF5qkYGGVLkDXPUecelb7LYt9OljvtsgV7ElYi+15wIenL4syMmpavLkkweNw917pi N2dyoIHUBWQ+epMJ6dS3tIqKSnabxVK/Cj0TslIoh4qchZV5+zxIKKKNH6VcfUG8WQgO KSCDCLFGSqmiPIKbi0waYHRcScD06J8EKCI294tsYc8INbekyfPSzdPikplE0cc9Q4Ex ax4EEH2ezRSuhG9PZwXnr9gEdkqHtjW/Fz7Tk7HIfVz6G7THZ4SCtGQJoDr5Xh2i9Gwh aDw9jfExWwh6VBVDo8pk4A4kDmAPhW+lGZOwuN+JadPHdXI9LFiWR0V4fDdjibBCvOgI wayA== X-Gm-Message-State: ALyK8tIjv5Dp53YE2TJiDJizq7V5jy+uaHLR7ziNo5bei7n6SeX+RP0bGh0glbzeFsB/MJoe X-Received: by 10.28.17.132 with SMTP id 126mr6940130wmr.90.1466959335375; Sun, 26 Jun 2016 09:42:15 -0700 (PDT) Received: from XPS13.localdomain (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id bh7sm7390424wjb.22.2016.06.26.09.42.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 26 Jun 2016 09:42:14 -0700 (PDT) From: Thomas Monjalon To: Panu Matilainen Cc: dev@dpdk.org Date: Sun, 26 Jun 2016 18:42:03 +0200 Message-Id: <1466959325-9426-6-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1466959325-9426-1-git-send-email-thomas.monjalon@6wind.com> References: <1466959325-9426-1-git-send-email-thomas.monjalon@6wind.com> Subject: [dpdk-dev] [PATCH v2 5/7] mk: fix external dependencies of crypto drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jun 2016 16:42:15 -0000 When linking drivers as shared libraries, the dependencies need to be marked as DT_NEEDED entries. The crypto dependencies (libsso and libIPSec) are static libraries. To make them linked in the shared PMDs, the code must relocatable: - libIPSec_MB.a must be built with -fPIC - libsso_kasumi.a must be built with KASUMI_CFLAGS=-DKASUMI_C Fixes: 924e84f87306 ("aesni_mb: add driver for multi buffer based crypto") Fixes: eec136f3c54f ("aesni_gcm: add driver for AES-GCM crypto operations") Fixes: 3aafc423cf4d ("snow3g: add driver for SNOW 3G library") Fixes: 2773c86d061a ("crypto/kasumi: add driver for KASUMI library") Signed-off-by: Thomas Monjalon --- drivers/crypto/aesni_gcm/Makefile | 3 ++- drivers/crypto/aesni_mb/Makefile | 3 ++- drivers/crypto/kasumi/Makefile | 3 ++- drivers/crypto/snow3g/Makefile | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/aesni_gcm/Makefile b/drivers/crypto/aesni_gcm/Makefile index ab5d2ed..5898cae 100644 --- a/drivers/crypto/aesni_gcm/Makefile +++ b/drivers/crypto/aesni_gcm/Makefile @@ -49,9 +49,10 @@ LIBABIVER := 1 # versioning export map EXPORT_MAP := rte_pmd_aesni_gcm_version.map -# external library include paths +# external library dependencies CFLAGS += -I$(AESNI_MULTI_BUFFER_LIB_PATH) CFLAGS += -I$(AESNI_MULTI_BUFFER_LIB_PATH)/include +LDLIBS += -L$(AESNI_MULTI_BUFFER_LIB_PATH) -lIPSec_MB LDLIBS += -lcrypto # library source files diff --git a/drivers/crypto/aesni_mb/Makefile b/drivers/crypto/aesni_mb/Makefile index 348a8bd..d3994cc 100644 --- a/drivers/crypto/aesni_mb/Makefile +++ b/drivers/crypto/aesni_mb/Makefile @@ -49,9 +49,10 @@ LIBABIVER := 1 # versioning export map EXPORT_MAP := rte_pmd_aesni_version.map -# external library include paths +# external library dependencies CFLAGS += -I$(AESNI_MULTI_BUFFER_LIB_PATH) CFLAGS += -I$(AESNI_MULTI_BUFFER_LIB_PATH)/include +LDLIBS += -L$(AESNI_MULTI_BUFFER_LIB_PATH) -lIPSec_MB # library source files SRCS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += rte_aesni_mb_pmd.c diff --git a/drivers/crypto/kasumi/Makefile b/drivers/crypto/kasumi/Makefile index 72b1ca4..9fb0be8 100644 --- a/drivers/crypto/kasumi/Makefile +++ b/drivers/crypto/kasumi/Makefile @@ -49,10 +49,11 @@ LIBABIVER := 1 # versioning export map EXPORT_MAP := rte_pmd_kasumi_version.map -# external library include paths +# external library dependencies CFLAGS += -I$(LIBSSO_KASUMI_PATH) CFLAGS += -I$(LIBSSO_KASUMI_PATH)/include CFLAGS += -I$(LIBSSO_KASUMI_PATH)/build +LDLIBS += -L$(LIBSSO_KASUMI_PATH)/build -lsso_kasumi # library source files SRCS-$(CONFIG_RTE_LIBRTE_PMD_KASUMI) += rte_kasumi_pmd.c diff --git a/drivers/crypto/snow3g/Makefile b/drivers/crypto/snow3g/Makefile index 582907f..bea6760 100644 --- a/drivers/crypto/snow3g/Makefile +++ b/drivers/crypto/snow3g/Makefile @@ -49,10 +49,11 @@ LIBABIVER := 1 # versioning export map EXPORT_MAP := rte_pmd_snow3g_version.map -# external library include paths +# external library dependencies CFLAGS += -I$(LIBSSO_SNOW3G_PATH) CFLAGS += -I$(LIBSSO_SNOW3G_PATH)/include CFLAGS += -I$(LIBSSO_SNOW3G_PATH)/build +LDLIBS += -L$(LIBSSO_SNOW3G_PATH)/build -lsso_snow3g # library source files SRCS-$(CONFIG_RTE_LIBRTE_PMD_SNOW3G) += rte_snow3g_pmd.c -- 2.7.0