From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0586F2B96 for ; Wed, 7 Dec 2016 16:00:16 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 07 Dec 2016 07:00:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="909711279" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga003.jf.intel.com with ESMTP; 07 Dec 2016 07:00:00 -0800 To: Wenzhuo Lu , dev@dpdk.org References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-22-git-send-email-wenzhuo.lu@intel.com> From: Ferruh Yigit Message-ID: <1466fda4-2097-b825-9e11-dc1aae63d803@intel.com> Date: Wed, 7 Dec 2016 14:59:59 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481081535-37448-22-git-send-email-wenzhuo.lu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 21/32] app/testpmd: use unicast promiscuous mode on i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 15:00:17 -0000 On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > Add testpmd CLI to set VF unicast promiscuous mode on i40e. > > Signed-off-by: Wenzhuo Lu > --- > app/test-pmd/cmdline.c | 92 +++++++++++++++++++++++++++++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 +++ > 2 files changed, 100 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 12126ce..d39712e 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -404,6 +404,11 @@ static void cmd_help_long_parsed(void *parsed_result, > "set allmulti (port_id|all) (on|off)\n" > " Set the allmulti mode on port_id, or all.\n\n" > > +#ifdef RTE_LIBRTE_I40E_PMD > + "set vf unicast-promisc (port_id) (vf_id) (on|off)\n" Previous usages are all "promisc" instead of "unicals-promisc". Is this to promisc mode for multicast packets? If so testpmd calls them "allmulti" I guess, so they won't cause trouble. Can we keep using command: "promisc"? <...> > + > +cmdline_parse_inst_t cmd_set_vf_unicast_promisc = { > + .f = cmd_set_vf_unicast_promisc_parsed, > + .data = NULL, > + .help_str = "set vf unicast promiscuous port_id vf_id on|off", Can you please differentiate the keyword and variable by wrapping variables with <>? Like: "set vf unicast-promiscuous on|off" <...> > > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index f1c269a..e17e3d5 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -820,6 +820,14 @@ Set the allmulti mode for a port or for all ports:: > > Same as the ifconfig (8) option. Controls how multicast packets are handled. > > +set unicast promisc (for VF) > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Should we mention this is PMD specific feature and only enabled with some PMDs? > + > +Set the unicast promiscuous mode for a VF from PF. > +In promiscuous mode packets are not dropped if they aren't for the specified MAC address:: > + > + testpmd> set vf unicast-promisc (port_id) (vf_id) (on|off) > + > set flow_ctrl rx > ~~~~~~~~~~~~~~~~ > >